-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shutdown api to pool #1380
base: main
Are you sure you want to change the base?
add shutdown api to pool #1380
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
==========================================
- Coverage 19.08% 19.07% -0.02%
==========================================
Files 166 166
Lines 11066 11080 +14
==========================================
+ Hits 2112 2113 +1
- Misses 8954 8967 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d21828a
to
4bcb567
Compare
…for graceful shutdown of role
…hard dependence on template provider
4bcb567
to
1cea297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as with #1376, I think we should wait with this for a bit
closes: #1320