Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shutdown api to pool #1380

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Shourya742
Copy link
Contributor

closes: #1320

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 19.07%. Comparing base (e228c19) to head (1cea297).

Files with missing lines Patch % Lines
roles/pool/src/lib/mining_pool/mod.rs 0.00% 12 Missing ⚠️
roles/pool/src/lib/mod.rs 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
- Coverage   19.08%   19.07%   -0.02%     
==========================================
  Files         166      166              
  Lines       11066    11080      +14     
==========================================
+ Hits         2112     2113       +1     
- Misses       8954     8967      +13     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.55% <ø> (ø)
binary_sv2-coverage 5.34% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.44% <ø> (+0.01%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.44% <ø> (ø)
pool_sv2-coverage 2.11% <4.54%> (+0.06%) ⬆️
protocols 24.57% <ø> (ø)
roles 6.54% <4.54%> (+<0.01%) ⬆️
roles_logic_sv2-coverage 7.93% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shourya742 Shourya742 force-pushed the 2025-01-22-add-shutdown-api-pool branch 2 times, most recently from d21828a to 4bcb567 Compare January 22, 2025 13:12
@plebhash plebhash added roles Pertains to all roles refactor Implies refactoring code labels Jan 22, 2025
@Shourya742 Shourya742 force-pushed the 2025-01-22-add-shutdown-api-pool branch from 4bcb567 to 1cea297 Compare January 23, 2025 05:02
Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with #1376, I think we should wait with this for a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implies refactoring code roles Pertains to all roles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Killing a running process(role) in integration tests
3 participants