Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to ensure the pool waits and connect to TP #1378

Conversation

Shourya742
Copy link
Contributor

closes: #1377

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 19.08%. Comparing base (4df7355) to head (2d45c62).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
roles/pool/src/lib/template_receiver/mod.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
- Coverage   19.09%   19.08%   -0.01%     
==========================================
  Files         166      166              
  Lines       11062    11066       +4     
==========================================
  Hits         2112     2112              
- Misses       8950     8954       +4     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.55% <ø> (ø)
binary_sv2-coverage 5.34% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.43% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.44% <ø> (ø)
pool_sv2-coverage 2.04% <0.00%> (-0.01%) ⬇️
protocols 24.57% <ø> (ø)
roles 6.54% <0.00%> (-0.01%) ⬇️
roles_logic_sv2-coverage 7.93% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roles/pool/src/lib/mod.rs Outdated Show resolved Hide resolved
@Shourya742 Shourya742 force-pushed the 2025-01-22-let-pool-wait-for-template-provider branch from bf9c363 to 75196f6 Compare January 22, 2025 11:45
@plebhash
Copy link
Collaborator

tACK

@plebhash plebhash added roles Pertains to all roles refactor Implies refactoring code bug Something isn't working ready-to-be-merged triggers auto rebase bot labels Jan 22, 2025
Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the sleep to 1 second tbh, but wont block this - I can change it later

@Shourya742
Copy link
Contributor Author

I would change the sleep to 1 second tbh, but wont block this - I can change it later

Let me change and push,

@Shourya742 Shourya742 force-pushed the 2025-01-22-let-pool-wait-for-template-provider branch from 1c98b68 to bd29cbf Compare January 22, 2025 15:00
@plebhash
Copy link
Collaborator

I would change the sleep to 1 second tbh, but wont block this - I can change it later

Let me change and push,

let's squash the commits into one

…te provider if the initial connection fails.
@Shourya742 Shourya742 force-pushed the 2025-01-22-let-pool-wait-for-template-provider branch from bd29cbf to 2d45c62 Compare January 22, 2025 15:04
@Shourya742
Copy link
Contributor Author

I would change the sleep to 1 second tbh, but wont block this - I can change it later

Let me change and push,

let's squash the commits into one

done

@plebhash plebhash merged commit 150360c into stratum-mining:main Jan 22, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-to-be-merged triggers auto rebase bot refactor Implies refactoring code roles Pertains to all roles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the pool wait for the template provider to start
3 participants