avoid running workflows AFTER merging PRs

[plebhash]

close #1372

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.08%. Comparing base (d96e4b0) to head (55fba7c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1373   +/-   ##
=======================================
  Coverage   19.08%   19.08%           
=======================================
  Files         166      166           
  Lines       11066    11066           
=======================================
  Hits         2112     2112           
  Misses       8954     8954           

Flag	Coverage Δ
binary_codec_sv2-coverage	0.00% <ø> (ø)
binary_serde_sv2-coverage	3.55% <ø> (ø)
binary_sv2-coverage	5.34% <ø> (ø)
bip32_derivation-coverage	0.00% <ø> (ø)
buffer_sv2-coverage	25.02% <ø> (ø)
codec_sv2-coverage	0.01% <ø> (ø)
common_messages_sv2-coverage	0.13% <ø> (ø)
const_sv2-coverage	0.00% <ø> (ø)
error_handling-coverage	0.00% <ø> (ø)
framing_sv2-coverage	0.28% <ø> (ø)
jd_client-coverage	0.00% <ø> (ø)
jd_server-coverage	7.79% <ø> (ø)
job_declaration_sv2-coverage	0.00% <ø> (ø)
key-utils-coverage	2.39% <ø> (ø)
mining-coverage	2.44% <ø> (ø)
mining_device-coverage	0.00% <ø> (ø)
mining_proxy_sv2-coverage	0.70% <ø> (ø)
noise_sv2-coverage	4.44% <ø> (ø)
pool_sv2-coverage	2.04% <ø> (ø)
protocols	24.57% <ø> (ø)
roles	6.54% <ø> (ø)
roles_logic_sv2-coverage	7.93% <ø> (ø)
sv2_ffi-coverage	0.00% <ø> (ø)
template_distribution_sv2-coverage	0.00% <ø> (ø)
translator_sv2-coverage	9.60% <ø> (ø)
utils	25.13% <ø> (ø)
v1-coverage	2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Shourya742]

ACK

The reason why we have a check on main once the PR is merged is because we want to check if multiple changes together has caused any issue or not. But currently how are workflow works is, even if the changes on main and the PR branch are unrelated, still the github excepts us to rebase and make our PR branch consistent to main. For our workflow removing the push to main branch check is ok. But it would have been ideal if we can have merge policies a bit sorted, like unrelated change need not to be rebased or stuff.

[jbesraa]

what if you push again to this pull request, would that rerun ci?

[plebhash]

what if you push again to this pull request, would that rerun ci?

just rebased against main, CI is re-running from scratch

[plebhash]

marked the two comments above as outdated, as the new Github UI seems a bit buggy

IMO we should just keep rebasing PRs against main and only run CI before the PR is merged

[Shourya742]

marked the two comments above as outdated, as the new Github UI seems a bit buggy

IMO we should just keep rebasing PRs against main and only run CI before the PR is merged

ACK.. We should be strict with it now onwards, as we are removing push on main