Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump derive_codec_sv2 as a consequence of Rust Docs #1303

Merged
merged 2 commits into from
Dec 18, 2024
Merged

bump derive_codec_sv2 as a consequence of Rust Docs #1303

merged 2 commits into from
Dec 18, 2024

Conversation

plebhash
Copy link
Collaborator

close #1285

only crate that still needs bumping from Rust Docs for completion of milestone v1.2.0 is derive_codec_sv2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump_derive_codec_sv2
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.08
(-0.92%)		46.50
(94.79%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		74.64
(-4.88%)		104.85
(71.19%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.64
(-0.08%)		14.71
(99.57%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		260.01
(-2.24%)		292.71
(88.83%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		616.33
(+0.48%)		649.20
(94.94%)
client_sv2_open_channel📈 view plot
🚷 view threshold		167.00
(+1.30%)		175.21
(95.32%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		286.93
(+0.67%)		310.35
(92.45%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		381.96
(-0.46%)		410.45
(93.06%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		160.30
(+0.18%)		170.99
(93.75%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		470.38
(-0.29%)		552.40
(85.15%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,051.50
(+5.91%)		1,111.81
(94.58%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump_derive_codec_sv2
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,574.90
(-0.74%)		7,049.50
(93.27%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,372.20
(-1.38%)		8,010.58
(92.03%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,046.40
(-1.10%)		9,366.67
(85.90%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		876.86
(+1.37%)		935.61
(93.72%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		681.06
(+1.28%)		714.70
(95.29%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		249.46
(+0.15%)		271.11
(92.02%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		157.02
(-0.14%)		166.31
(94.41%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,242.90
(-2.54%)		7,002.53
(89.15%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		280.77
(-0.33%)		317.32
(88.48%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		760.66
(+4.53%)		784.19
(97.00%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		600.35
(+2.20%)		616.19
(97.43%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		203.72
(-1.28%)		223.96
(90.96%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump_derive_codec_sv2
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,279.00
(-2.11%)		8,682.46
(95.35%)		📈 view plot
🚷 view threshold		3,661.00
(-1.97%)		3,864.57
(94.73%)		📈 view plot
🚷 view threshold		5,119.00
(-2.14%)		5,451.22
(93.91%)		📈 view plot
🚷 view threshold		9.00
(+13.61%)		15.48
(58.12%)		📈 view plot
🚷 view threshold		89.00
(-2.25%)		96.00
(92.71%)
get_submit📈 view plot
🚷 view threshold		95,127.00
(-0.27%)		95,741.60
(99.36%)		📈 view plot
🚷 view threshold		59,318.00
(-0.18%)		59,715.54
(99.33%)		📈 view plot
🚷 view threshold		85,182.00
(-0.19%)		85,830.29
(99.24%)		📈 view plot
🚷 view threshold		50.00
(+13.03%)		59.31
(84.30%)		📈 view plot
🚷 view threshold		277.00
(-1.24%)		290.58
(95.33%)
get_subscribe📈 view plot
🚷 view threshold		7,768.00
(-2.99%)		8,240.58
(94.27%)		📈 view plot
🚷 view threshold		2,737.00
(-3.01%)		2,943.96
(92.97%)		📈 view plot
🚷 view threshold		3,808.00
(-3.33%)		4,144.12
(91.89%)		📈 view plot
🚷 view threshold		15.00
(+25.33%)		19.79
(75.80%)		📈 view plot
🚷 view threshold		111.00
(-3.08%)		117.89
(94.15%)
serialize_authorize📈 view plot
🚷 view threshold		12,000.00
(-2.19%)		12,517.84
(95.86%)		📈 view plot
🚷 view threshold		5,238.00
(-1.31%)		5,429.31
(96.48%)		📈 view plot
🚷 view threshold		7,290.00
(-1.42%)		7,606.40
(95.84%)		📈 view plot
🚷 view threshold		11.00
(+13.00%)		18.33
(60.02%)		📈 view plot
🚷 view threshold		133.00
(-3.53%)		142.34
(93.44%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,524.00
(-0.75%)		25,182.56
(97.38%)		📈 view plot
🚷 view threshold		9,810.00
(-0.61%)		10,027.82
(97.83%)		📈 view plot
🚷 view threshold		13,839.00
(-0.65%)		14,194.72
(97.49%)		📈 view plot
🚷 view threshold		37.00
(+4.80%)		45.32
(81.64%)		📈 view plot
🚷 view threshold		300.00
(-0.98%)		313.40
(95.73%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		29,994.00
(-1.11%)		30,715.89
(97.65%)		📈 view plot
🚷 view threshold		11,987.00
(-0.62%)		12,199.28
(98.26%)		📈 view plot
🚷 view threshold		16,964.00
(-0.67%)		17,308.16
(98.01%)		📈 view plot
🚷 view threshold		58.00
(+4.34%)		67.04
(86.51%)		📈 view plot
🚷 view threshold		364.00
(-1.80%)		379.40
(95.94%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,257.00
(-0.17%)		126,778.11
(99.59%)		📈 view plot
🚷 view threshold		73,200.00
(-0.09%)		73,526.84
(99.56%)		📈 view plot
🚷 view threshold		104,912.00
(-0.11%)		105,493.17
(99.45%)		📈 view plot
🚷 view threshold		111.00
(+4.85%)		124.42
(89.21%)		📈 view plot
🚷 view threshold		594.00
(-0.59%)		607.86
(97.72%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,598.00
(-1.08%)		28,440.34
(97.04%)		📈 view plot
🚷 view threshold		9,556.00
(-0.86%)		9,757.65
(97.93%)		📈 view plot
🚷 view threshold		13,498.00
(-0.96%)		13,832.80
(97.58%)		📈 view plot
🚷 view threshold		69.00
(+7.97%)		76.67
(89.99%)		📈 view plot
🚷 view threshold		393.00
(-1.40%)		411.72
(95.45%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,183.00
(-0.06%)		115,724.95
(99.53%)		📈 view plot
🚷 view threshold		68,060.00
(-0.02%)		68,420.77
(99.47%)		📈 view plot
🚷 view threshold		97,648.00
(-0.04%)		98,287.12
(99.35%)		📈 view plot
🚷 view threshold		70.00
(+9.54%)		84.46
(82.88%)		📈 view plot
🚷 view threshold		491.00
(-0.36%)		501.52
(97.90%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,076.00
(-1.02%)		23,851.59
(96.75%)		📈 view plot
🚷 view threshold		8,115.00
(-0.96%)		8,314.31
(97.60%)		📈 view plot
🚷 view threshold		11,411.00
(-1.09%)		11,741.74
(97.18%)		📈 view plot
🚷 view threshold		44.00
(+15.34%)		49.12
(89.58%)		📈 view plot
🚷 view threshold		327.00
(-1.22%)		343.60
(95.17%)
serialize_submit📈 view plot
🚷 view threshold		99,508.00
(-0.30%)		100,185.92
(99.32%)		📈 view plot
🚷 view threshold		61,380.00
(-0.15%)		61,742.01
(99.41%)		📈 view plot
🚷 view threshold		88,043.00
(-0.17%)		88,658.31
(99.31%)		📈 view plot
🚷 view threshold		53.00
(+12.50%)		65.10
(81.42%)		📈 view plot
🚷 view threshold		320.00
(-1.61%)		335.87
(95.28%)
serialize_subscribe📈 view plot
🚷 view threshold		11,213.00
(-1.69%)		11,616.80
(96.52%)		📈 view plot
🚷 view threshold		4,090.00
(-1.93%)		4,284.31
(95.46%)		📈 view plot
🚷 view threshold		5,668.00
(-2.22%)		5,997.17
(94.51%)		📈 view plot
🚷 view threshold		17.00
(+28.30%)		22.52
(75.50%)		📈 view plot
🚷 view threshold		156.00
(-1.49%)		163.65
(95.32%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branchbump_derive_codec_sv2
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,125.00
(+0.81%)		2,224.38
(95.53%)		📈 view plot
🚷 view threshold		473.00
(-0.05%)		488.96
(96.74%)		📈 view plot
🚷 view threshold		735.00
(-0.08%)		758.01
(96.96%)		📈 view plot
🚷 view threshold		5.00
(-2.44%)		12.93
(38.66%)		📈 view plot
🚷 view threshold		39.00
(+1.36%)		41.53
(93.91%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,306.00
(+1.06%)		8,376.31
(99.16%)		📈 view plot
🚷 view threshold		2,137.00
(-0.02%)		2,142.26
(99.75%)		📈 view plot
🚷 view threshold		3,156.00
(-0.12%)		3,170.54
(99.54%)		📈 view plot
🚷 view threshold		36.00
(+1.43%)		41.65
(86.43%)		📈 view plot
🚷 view threshold		142.00
(+1.81%)		143.83
(98.73%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,353.00
(+0.89%)		6,439.11
(98.66%)		📈 view plot
🚷 view threshold		1,750.00
(-0.04%)		1,766.91
(99.04%)		📈 view plot
🚷 view threshold		2,548.00
(-0.16%)		2,575.46
(98.93%)		📈 view plot
🚷 view threshold		19.00
(+11.41%)		24.38
(77.92%)		📈 view plot
🚷 view threshold		106.00
(+1.38%)		108.52
(97.68%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,804.00
(+0.54%)		14,937.17
(99.11%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,710.91
(99.64%)		📈 view plot
🚷 view threshold		6,749.00
(-0.12%)		6,785.98
(99.46%)		📈 view plot
🚷 view threshold		50.00
(+12.06%)		59.84
(83.56%)		📈 view plot
🚷 view threshold		223.00
(+0.79%)		226.55
(98.43%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,800.00
(+0.81%)		27,979.46
(99.36%)		📈 view plot
🚷 view threshold		10,645.00
(+0.42%)		10,680.59
(99.67%)		📈 view plot
🚷 view threshold		15,500.00
(+0.46%)		15,564.26
(99.59%)		📈 view plot
🚷 view threshold		94.00
(+13.66%)		96.44
(97.47%)		📈 view plot
🚷 view threshold		338.00
(+0.82%)		342.31
(98.74%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,443.00
(+1.25%)		4,546.93
(97.71%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,476.96
(98.92%)		📈 view plot
🚷 view threshold		2,158.00
(-0.12%)		2,183.65
(98.83%)		📈 view plot
🚷 view threshold		9.00
(+9.61%)		14.24
(63.20%)		📈 view plot
🚷 view threshold		64.00
(+2.44%)		66.97
(95.56%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,040.00
(+0.16%)		14,194.17
(98.91%)		📈 view plot
🚷 view threshold		5,064.00
(-0.00%)		5,079.96
(99.69%)		📈 view plot
🚷 view threshold		7,320.00
(-0.09%)		7,351.42
(99.57%)		📈 view plot
🚷 view threshold		42.00
(+17.43%)		46.64
(90.06%)		📈 view plot
🚷 view threshold		186.00
(-0.04%)		191.11
(97.33%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,824.00
(+0.64%)		22,979.56
(99.32%)		📈 view plot
🚷 view threshold		8,040.00
(+0.12%)		8,052.75
(99.84%)		📈 view plot
🚷 view threshold		11,689.00
(+0.05%)		11,710.70
(99.81%)		📈 view plot
🚷 view threshold		85.00
(+13.13%)		87.92
(96.68%)		📈 view plot
🚷 view threshold		306.00
(+0.83%)		310.74
(98.47%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,707.00
(+0.44%)		4,784.43
(98.38%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.96
(98.95%)		📈 view plot
🚷 view threshold		2,277.00
(-0.05%)		2,299.50
(99.02%)		📈 view plot
🚷 view threshold		10.00
(+4.07%)		16.14
(61.95%)		📈 view plot
🚷 view threshold		68.00
(+0.83%)		70.02
(97.12%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,214.00
(+0.41%)		16,302.88
(99.45%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,978.96
(99.73%)		📈 view plot
🚷 view threshold		8,654.00
(-0.12%)		8,691.47
(99.57%)		📈 view plot
🚷 view threshold		49.00
(+22.50%)		54.14
(90.51%)		📈 view plot
🚷 view threshold		209.00
(+0.43%)		211.84
(98.66%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,756.00
(+0.50%)		35,881.45
(99.65%)		📈 view plot
🚷 view threshold		14,888.00
(+0.17%)		14,909.01
(99.86%)		📈 view plot
🚷 view threshold		21,866.00
(+0.13%)		21,907.41
(99.81%)		📈 view plot
🚷 view threshold		111.00
(+19.79%)		113.89
(97.46%)		📈 view plot
🚷 view threshold		381.00
(+0.44%)		385.01
(98.96%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.39%. Comparing base (789bb5e) to head (d75cb04).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
- Coverage   19.29%   17.39%   -1.91%     
==========================================
  Files         164      163       -1     
  Lines       10852    10678     -174     
==========================================
- Hits         2094     1857     -237     
- Misses       8758     8821      +63
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols ?
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash plebhash force-pushed the bump_derive_codec_sv2 branch from 2fc78c6 to d75cb04 Compare December 18, 2024 13:25
Shourya742
Shourya742 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@plebhash plebhash added ready-to-be-merged triggers auto rebase bot version-bump version bump for release management labels Dec 18, 2024
@plebhash plebhash merged commit 6171b37 into stratum-mining:main Dec 18, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shourya742 Shourya742 Shourya742 approved these changes

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
ready-to-be-merged triggers auto rebase bot version-bump version bump for release management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version bumping as a consequence of Rust Docs on milestone 1.2.0
3 participants
@plebhash @GitGab19 @Shourya742