Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify logging #1295

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: clarify logging #1295

merged 1 commit into from
Jan 3, 2025

Conversation

average-gary
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

🐰 Bencher Report

Branchfix/logging
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.41
(-1.60%)		57.95
(76.63%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		75.59
(-2.68%)		103.19
(73.25%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.67
(+0.03%)		14.71
(99.70%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		266.15
(+0.06%)		288.72
(92.18%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		618.90
(+0.95%)		645.32
(95.91%)
client_sv2_open_channel📈 view plot
🚷 view threshold		165.30
(+0.16%)		176.69
(93.55%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		301.08
(+5.42%)		311.65
(96.61%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		379.98
(-0.86%)		407.33
(93.29%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		162.84
(+1.69%)		170.97
(95.25%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		461.77
(-1.77%)		548.83
(84.14%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,058.30
(+5.61%)		1,145.39
(92.40%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

🐰 Bencher Report

Branchfix/logging
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
1e3 x instructions
(Result Δ%)		Upper Boundary
1e3 x instructions
(Limit %)		L1 AccessesBenchmark Result
1e3 x accesses
(Result Δ%)		Upper Boundary
1e3 x accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8.42
(-0.38%)		8.67
(97.10%)		📈 view plot
🚷 view threshold		3.69
(-1.10%)		3.86
(95.56%)		📈 view plot
🚷 view threshold		5.16
(-1.29%)		5.44
(94.71%)		📈 view plot
🚷 view threshold		9.00
(+9.92%)		15.62
(57.63%)		📈 view plot
🚷 view threshold		92.00
(+0.97%)		96.15
(95.69%)
get_submit📈 view plot
🚷 view threshold		95.23
(-0.13%)		95.65
(99.57%)		📈 view plot
🚷 view threshold		59.35
(-0.12%)		59.70
(99.40%)		📈 view plot
🚷 view threshold		85.22
(-0.13%)		85.81
(99.31%)		📈 view plot
🚷 view threshold		50.00
(+12.66%)		59.95
(83.41%)		📈 view plot
🚷 view threshold		279.00
(-0.46%)		290.19
(96.14%)
get_subscribe📈 view plot
🚷 view threshold		7.91
(-1.07%)		8.23
(96.11%)		📈 view plot
🚷 view threshold		2.77
(-1.86%)		2.94
(93.94%)		📈 view plot
🚷 view threshold		3.84
(-2.23%)		4.14
(92.78%)		📈 view plot
🚷 view threshold		16.00
(+30.11%)		20.39
(78.45%)		📈 view plot
🚷 view threshold		114.00
(-0.42%)		117.78
(96.79%)
serialize_authorize📈 view plot
🚷 view threshold		12.14
(-0.95%)		12.51
(97.08%)		📈 view plot
🚷 view threshold		5.27
(-0.70%)		5.43
(97.07%)		📈 view plot
🚷 view threshold		7.33
(-0.82%)		7.60
(96.42%)		📈 view plot
🚷 view threshold		11.00
(+10.26%)		18.49
(59.50%)		📈 view plot
🚷 view threshold		136.00
(-1.26%)		142.40
(95.51%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24.71
(-0.02%)		25.18
(98.12%)		📈 view plot
🚷 view threshold		9.84
(-0.26%)		10.01
(98.27%)		📈 view plot
🚷 view threshold		13.87
(-0.33%)		14.17
(97.89%)		📈 view plot
🚷 view threshold		39.00
(+8.97%)		45.69
(85.35%)		📈 view plot
🚷 view threshold		304.00
(+0.24%)		313.04
(97.11%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30.23
(-0.32%)		30.72
(98.38%)		📈 view plot
🚷 view threshold		12.02
(-0.34%)		12.19
(98.58%)		📈 view plot
🚷 view threshold		16.99
(-0.44%)		17.29
(98.26%)		📈 view plot
🚷 view threshold		64.00
(+14.78%)		67.43
(94.91%)		📈 view plot
🚷 view threshold		369.00
(-0.49%)		379.12
(97.33%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126.28
(-0.14%)		126.78
(99.60%)		📈 view plot
🚷 view threshold		73.20
(-0.08%)		73.52
(99.56%)		📈 view plot
🚷 view threshold		104.91
(-0.10%)		105.49
(99.45%)		📈 view plot
🚷 view threshold		116.00
(+9.22%)		125.52
(92.42%)		📈 view plot
🚷 view threshold		594.00
(-0.55%)		608.21
(97.66%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27.83
(-0.30%)		28.40
(97.98%)		📈 view plot
🚷 view threshold		9.58
(-0.54%)		9.76
(98.20%)		📈 view plot
🚷 view threshold		13.53
(-0.69%)		13.84
(97.78%)		📈 view plot
🚷 view threshold		74.00
(+14.94%)		77.77
(95.15%)		📈 view plot
🚷 view threshold		398.00
(-0.26%)		410.09
(97.05%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115.18
(-0.05%)		115.71
(99.55%)		📈 view plot
🚷 view threshold		68.06
(-0.01%)		68.41
(99.49%)		📈 view plot
🚷 view threshold		97.65
(-0.02%)		98.27
(99.37%)		📈 view plot
🚷 view threshold		70.00
(+8.40%)		85.83
(81.55%)		📈 view plot
🚷 view threshold		491.00
(-0.36%)		501.92
(97.82%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23.25
(-0.33%)		23.83
(97.57%)		📈 view plot
🚷 view threshold		8.14
(-0.58%)		8.31
(97.93%)		📈 view plot
🚷 view threshold		11.45
(-0.71%)		11.74
(97.49%)		📈 view plot
🚷 view threshold		43.00
(+11.19%)		50.48
(85.18%)		📈 view plot
🚷 view threshold		331.00
(-0.13%)		342.50
(96.64%)
serialize_submit📈 view plot
🚷 view threshold		99.62
(-0.17%)		100.11
(99.51%)		📈 view plot
🚷 view threshold		61.41
(-0.09%)		61.73
(99.48%)		📈 view plot
🚷 view threshold		88.08
(-0.11%)		88.64
(99.37%)		📈 view plot
🚷 view threshold		54.00
(+13.42%)		66.07
(81.73%)		📈 view plot
🚷 view threshold		322.00
(-0.91%)		335.55
(95.96%)
serialize_subscribe📈 view plot
🚷 view threshold		11.36
(-0.38%)		11.60
(97.91%)		📈 view plot
🚷 view threshold		4.12
(-1.16%)		4.28
(96.13%)		📈 view plot
🚷 view threshold		5.71
(-1.46%)		6.00
(95.14%)		📈 view plot
🚷 view threshold		17.00
(+25.20%)		23.34
(72.83%)		📈 view plot
🚷 view threshold		159.00
(+0.43%)		163.58
(97.20%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

🐰 Bencher Report

Branchfix/logging
Testbedsv2

🚨 1 Alert

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		91.00
(+20.57%)		89.85
(101.28%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2.17
(+2.68%)		2.23
(97.03%)		📈 view plot
🚷 view threshold		473.00
(-0.09%)		490.93
(96.35%)		📈 view plot
🚷 view threshold		732.00
(-0.53%)		759.92
(96.33%)		📈 view plot
🚷 view threshold		7.00
(+40.44%)		12.02
(58.24%)		📈 view plot
🚷 view threshold		40.00
(+3.73%)		41.64
(96.07%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8.28
(+0.76%)		8.39
(98.78%)		📈 view plot
🚷 view threshold		2,137.00
(-0.00%)		2,139.44
(99.89%)		📈 view plot
🚷 view threshold		3,154.00
(-0.16%)		3,168.58
(99.54%)		📈 view plot
🚷 view threshold		39.00
(+9.67%)		41.90
(93.09%)		📈 view plot
🚷 view threshold		141.00
(+1.04%)		144.13
(97.83%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6.33
(+0.59%)		6.44
(98.34%)		📈 view plot
🚷 view threshold		1,750.00
(-0.03%)		1,767.95
(98.98%)		📈 view plot
🚷 view threshold		2,545.00
(-0.27%)		2,576.37
(98.78%)		📈 view plot
🚷 view threshold		23.00
(+34.00%)		24.73
(93.01%)		📈 view plot
🚷 view threshold		105.00
(+0.40%)		108.57
(96.71%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14.80
(+0.51%)		14.93
(99.12%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,711.95
(99.62%)		📈 view plot
🚷 view threshold		6,743.00
(-0.20%)		6,786.81
(99.35%)		📈 view plot
🚷 view threshold		57.00
(+26.47%)		61.73
(92.34%)		📈 view plot
🚷 view threshold		222.00
(+0.38%)		226.15
(98.16%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27.82
(+0.85%)		28.02
(99.30%)		📈 view plot
🚷 view threshold		10,645.00
(+0.39%)		10,690.93
(99.57%)		📈 view plot
🚷 view threshold		15,495.00
(+0.40%)		15,580.15
(99.45%)		📈 view plot
🚷 view threshold		99.00
(+18.71%)		99.13
(99.87%)		📈 view plot
🚷 view threshold		338.00
(+0.81%)		342.45
(98.70%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4.49
(+2.14%)		4.56
(98.42%)		📈 view plot
🚷 view threshold		1,461.00
(-0.03%)		1,478.93
(98.79%)		📈 view plot
🚷 view threshold		2,154.00
(-0.31%)		2,185.32
(98.57%)		📈 view plot
🚷 view threshold		12.00
(+47.83%)		13.99
(85.78%)		📈 view plot
🚷 view threshold		65.00
(+3.71%)		67.19
(96.74%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14.09
(+0.49%)		14.19
(99.26%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,081.93
(99.65%)		📈 view plot
🚷 view threshold		7,316.00
(-0.14%)		7,353.00
(99.50%)		📈 view plot
🚷 view threshold		45.00
(+24.51%)		47.71
(94.33%)		📈 view plot
🚷 view threshold		187.00
(+0.54%)		190.85
(97.98%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22.88
(+0.85%)		23.01
(99.43%)		📈 view plot
🚷 view threshold		8,040.00
(+0.11%)		8,056.59
(99.79%)		📈 view plot
🚷 view threshold		11,682.00
(-0.01%)		11,713.72
(99.73%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		91.00
(+20.57%)		89.85
(101.28%)		📈 view plot
🚷 view threshold		307.00
(+1.09%)		311.23
(98.64%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4.72
(+0.66%)		4.79
(98.56%)		📈 view plot
🚷 view threshold		1,502.00
(-0.03%)		1,519.93
(98.82%)		📈 view plot
🚷 view threshold		2,274.00
(-0.20%)		2,301.78
(98.79%)		📈 view plot
🚷 view threshold		13.00
(+37.63%)		15.63
(83.17%)		📈 view plot
🚷 view threshold		68.00
(+0.74%)		70.03
(97.11%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16.23
(+0.49%)		16.31
(99.50%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,980.93
(99.70%)		📈 view plot
🚷 view threshold		8,650.00
(-0.16%)		8,692.89
(99.51%)		📈 view plot
🚷 view threshold		53.00
(+32.24%)		54.82
(96.67%)		📈 view plot
🚷 view threshold		209.00
(+0.41%)		211.91
(98.63%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35.83
(+0.68%)		35.92
(99.76%)		📈 view plot
🚷 view threshold		14,888.00
(+0.15%)		14,915.48
(99.82%)		📈 view plot
🚷 view threshold		21,862.00
(+0.10%)		21,914.16
(99.76%)		📈 view plot
🚷 view threshold		113.00
(+20.90%)		117.76
(95.96%)		📈 view plot
🚷 view threshold		383.00
(+0.93%)		385.23
(99.42%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

🐰 Bencher Report

Branchfix/logging
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,533.50
(-0.73%)		6,905.56
(94.61%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,307.90
(-1.57%)		7,831.26
(93.32%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,941.60
(-1.88%)		9,229.02
(86.05%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		859.88
(-0.78%)		938.26
(91.65%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		667.24
(-1.02%)		716.85
(93.08%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		256.49
(+2.79%)		270.45
(94.84%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		156.81
(-0.40%)		165.88
(94.53%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,261.00
(-1.42%)		6,775.66
(92.40%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		277.86
(-1.49%)		322.21
(86.24%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		732.23
(+0.60%)		774.94
(94.49%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		595.85
(+0.99%)		625.38
(95.28%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		210.37
(+1.92%)		223.47
(94.14%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (a58246a) to head (214bf15).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files         164      164           
  Lines       10852    10852           
=======================================
  Hits         2094     2094           
  Misses       8758     8758
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.49% <ø> (-0.02%) ⬇️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash
Copy link
Collaborator

hey @average-gary thanks for this

could you provide more context on this PR?

GitGab19
GitGab19 previously approved these changes Dec 14, 2024
View reviewed changes
@GitGab19 GitGab19 dismissed their stale review December 14, 2024 10:36

haven't seen plebhash request

@average-gary
Copy link
Contributor Author

hey @average-gary thanks for this

could you provide more context on this PR?

It's logging "SHUTDOWN" but the match arm is for Reconnect.

@plebhash plebhash added the ready-to-be-merged triggers auto rebase bot label Jan 2, 2025
@plebhash plebhash merged commit 1f2c5e8 into stratum-mining:main Jan 3, 2025
37 checks passed
@plebhash plebhash mentioned this pull request Jan 3, 2025
Open
@average-gary average-gary deleted the fix/logging branch January 3, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash approved these changes

@GitGab19 GitGab19 GitGab19 left review comments

Assignees
No one assigned
Labels
ready-to-be-merged triggers auto rebase bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@average-gary @plebhash @GitGab19