Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor warning and error grammar and typo fixes #1281

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Minor warning and error grammar and typo fixes #1281

merged 2 commits into from
Dec 10, 2024

Conversation

pavlenex
Copy link
Collaborator

@pavlenex pavlenex commented Dec 9, 2024 •
edited by plebhash
Loading

motivated by #1280

good to have, but doesn't close the #1280 yet

pavlenex
pavlenex commented Dec 9, 2024
View reviewed changes
roles/jd-client/src/lib/upstream_sv2/upstream.rs
@@ -699,7 +699,7 @@ impl ParseUpstreamMiningMessages<Downstream, NullDownstreamMiningSelector, NoRou
&mut self,
_: roles_logic_sv2::mining_sv2::SetNewPrevHash,
) -> Result<roles_logic_sv2::handlers::mining::SendTo<Downstream>, RolesLogicError> {
warn!("SNPH received from upstream, proxy ignore it, and use the one declared by JOB DECLARATOR");
warn!("SNPH received from upstream, proxy ignored it, and used the one declared by JDC");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone needs to double check if it's JDC. JD seemed a bit generic, I tried to specify it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

🐰 Bencher Report

Branchtypo-fixes
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.06
(-1.18%)		46.99
(93.77%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		74.38
(-1.85%)		90.28
(82.39%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.66
(-0.03%)		14.77
(99.22%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		266.48
(+1.07%)		297.11
(89.69%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		625.31
(+1.82%)		686.47
(91.09%)
client_sv2_open_channel📈 view plot
🚷 view threshold		173.02
(+9.50%)		198.35
(87.23%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		279.30
(-2.06%)		313.01
(89.23%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		383.99
(+0.28%)		414.68
(92.60%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		157.61
(-1.55%)		168.76
(93.39%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		474.80
(+0.48%)		557.31
(85.20%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,017.70
(+2.90%)		1,098.58
(92.64%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

🐰 Bencher Report

Branchtypo-fixes
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,636.50
(-0.50%)		7,198.31
(92.20%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,396.50
(-2.22%)		8,165.96
(90.58%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,025.40
(-1.35%)		8,675.35
(92.51%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		847.96
(-1.76%)		921.36
(92.03%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		656.06
(-2.43%)		712.04
(92.14%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		246.23
(-1.05%)		271.86
(90.57%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		156.06
(-0.60%)		162.25
(96.18%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,369.10
(-1.62%)		7,175.09
(88.77%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		274.05
(-1.78%)		303.36
(90.34%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		728.87
(+0.09%)		782.76
(93.12%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		589.46
(-0.44%)		637.30
(92.49%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		206.62
(+0.49%)		215.12
(96.05%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

🐰 Bencher Report

Branchtypo-fixes
Testbedsv2

🚨 3 Alerts

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_handle_message_miningRAM Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		142.00
(+2.07%)		141.98
(100.02%)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		95.00
(+15.95%)		92.85
(102.32%)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		87.00
(+16.40%)		86.30
(100.81%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,163.00
(+3.02%)		2,216.36
(97.59%)		📈 view plot
🚷 view threshold		473.00
(-0.09%)		488.63
(96.80%)		📈 view plot
🚷 view threshold		733.00
(-0.41%)		757.33
(96.79%)		📈 view plot
🚷 view threshold		6.00
(+14.46%)		13.32
(45.03%)		📈 view plot
🚷 view threshold		40.00
(+4.68%)		41.41
(96.60%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,310.00
(+1.26%)		8,313.08
(99.96%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,155.00
(-0.18%)		3,170.87
(99.50%)		📈 view plot
🚷 view threshold		37.00
(+4.66%)		41.24
(89.73%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		142.00
(+2.07%)		141.98
(100.02%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,399.00
(+1.81%)		6,415.29
(99.75%)		📈 view plot
🚷 view threshold		1,750.00
(-0.06%)		1,766.96
(99.04%)		📈 view plot
🚷 view threshold		2,544.00
(-0.37%)		2,575.82
(98.76%)		📈 view plot
🚷 view threshold		22.00
(+29.65%)		24.38
(90.24%)		📈 view plot
🚷 view threshold		107.00
(+2.68%)		107.78
(99.27%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,858.00
(+0.90%)		14,943.05
(99.43%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,710.96
(99.64%)		📈 view plot
🚷 view threshold		6,743.00
(-0.23%)		6,783.17
(99.41%)		📈 view plot
🚷 view threshold		55.00
(+25.58%)		55.60
(98.92%)		📈 view plot
🚷 view threshold		224.00
(+1.19%)		227.01
(98.67%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,838.00
(+1.05%)		27,880.82
(99.85%)		📈 view plot
🚷 view threshold		10,645.00
(+0.52%)		10,667.48
(99.79%)		📈 view plot
🚷 view threshold		15,498.00
(+0.56%)		15,538.95
(99.74%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		95.00
(+15.95%)		92.85
(102.32%)		📈 view plot
🚷 view threshold		339.00
(+1.18%)		341.57
(99.25%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,485.00
(+2.15%)		4,576.30
(98.01%)		📈 view plot
🚷 view threshold		1,461.00
(-0.03%)		1,476.63
(98.94%)		📈 view plot
🚷 view threshold		2,155.00
(-0.25%)		2,183.70
(98.69%)		📈 view plot
🚷 view threshold		11.00
(+27.31%)		16.31
(67.46%)		📈 view plot
🚷 view threshold		65.00
(+4.03%)		67.52
(96.27%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,078.00
(+0.31%)		14,313.65
(98.35%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,079.63
(99.69%)		📈 view plot
🚷 view threshold		7,318.00
(-0.12%)		7,351.02
(99.55%)		📈 view plot
🚷 view threshold		43.00
(+21.69%)		44.79
(96.01%)		📈 view plot
🚷 view threshold		187.00
(+0.21%)		194.63
(96.08%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,866.00
(+0.88%)		22,928.93
(99.73%)		📈 view plot
🚷 view threshold		8,040.00
(+0.18%)		8,069.21
(99.64%)		📈 view plot
🚷 view threshold		11,686.00
(+0.09%)		11,742.27
(99.52%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		87.00
(+16.40%)		86.30
(100.81%)		📈 view plot
🚷 view threshold		307.00
(+1.21%)		310.33
(98.93%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,749.00
(+1.35%)		4,781.09
(99.33%)		📈 view plot
🚷 view threshold		1,502.00
(-0.03%)		1,517.63
(98.97%)		📈 view plot
🚷 view threshold		2,274.00
(-0.19%)		2,299.22
(98.90%)		📈 view plot
🚷 view threshold		12.00
(+24.47%)		16.55
(72.51%)		📈 view plot
🚷 view threshold		69.00
(+2.36%)		69.95
(98.65%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,252.00
(+0.57%)		16,410.91
(99.03%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,978.63
(99.74%)		📈 view plot
🚷 view threshold		8,652.00
(-0.14%)		8,691.14
(99.55%)		📈 view plot
🚷 view threshold		50.00
(+25.27%)		53.51
(93.44%)		📈 view plot
🚷 view threshold		210.00
(+0.73%)		214.97
(97.69%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,790.00
(+0.64%)		35,819.59
(99.92%)		📈 view plot
🚷 view threshold		14,888.00
(+0.22%)		14,912.07
(99.84%)		📈 view plot
🚷 view threshold		21,865.00
(+0.18%)		21,922.21
(99.74%)		📈 view plot
🚷 view threshold		111.00
(+20.28%)		112.09
(99.03%)		📈 view plot
🚷 view threshold		382.00
(+0.71%)		384.95
(99.23%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

🐰 Bencher Report

Branchtypo-fixes
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,383.00
(-0.94%)		8,731.53
(96.01%)		📈 view plot
🚷 view threshold		3,666.00
(-2.10%)		3,869.21
(94.75%)		📈 view plot
🚷 view threshold		5,113.00
(-2.58%)		5,450.12
(93.81%)		📈 view plot
🚷 view threshold		10.00
(+35.02%)		14.17
(70.55%)		📈 view plot
🚷 view threshold		92.00
(+1.35%)		95.62
(96.21%)
get_submit📈 view plot
🚷 view threshold		95,301.00
(-0.12%)		95,873.74
(99.40%)		📈 view plot
🚷 view threshold		59,266.00
(-0.31%)		59,715.51
(99.25%)		📈 view plot
🚷 view threshold		85,076.00
(-0.36%)		85,818.51
(99.13%)		📈 view plot
🚷 view threshold		50.00
(+12.26%)		61.93
(80.74%)		📈 view plot
🚷 view threshold		285.00
(+1.68%)		290.06
(98.26%)
get_subscribe📈 view plot
🚷 view threshold		7,904.00
(-1.41%)		8,278.97
(95.47%)		📈 view plot
🚷 view threshold		2,761.00
(-2.45%)		2,946.86
(93.69%)		📈 view plot
🚷 view threshold		3,834.00
(-3.03%)		4,139.18
(92.63%)		📈 view plot
🚷 view threshold		16.00
(+33.77%)		20.60
(77.68%)		📈 view plot
🚷 view threshold		114.00
(-0.33%)		118.62
(96.11%)
serialize_authorize📈 view plot
🚷 view threshold		12,168.00
(-0.93%)		12,567.28
(96.82%)		📈 view plot
🚷 view threshold		5,243.00
(-1.38%)		5,435.64
(96.46%)		📈 view plot
🚷 view threshold		7,283.00
(-1.74%)		7,606.76
(95.74%)		📈 view plot
🚷 view threshold		11.00
(+19.12%)		16.83
(65.37%)		📈 view plot
🚷 view threshold		138.00
(+0.11%)		142.58
(96.78%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,605.00
(-0.39%)		25,209.35
(97.60%)		📈 view plot
🚷 view threshold		9,789.00
(-0.97%)		10,046.00
(97.44%)		📈 view plot
🚷 view threshold		13,790.00
(-1.18%)		14,211.90
(97.03%)		📈 view plot
🚷 view threshold		35.00
(+0.97%)		43.66
(80.16%)		📈 view plot
🚷 view threshold		304.00
(+0.63%)		314.74
(96.59%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,238.00
(-0.30%)		30,746.21
(98.35%)		📈 view plot
🚷 view threshold		11,992.00
(-0.69%)		12,212.51
(98.19%)		📈 view plot
🚷 view threshold		16,953.00
(-0.85%)		17,314.67
(97.91%)		📈 view plot
🚷 view threshold		60.00
(+8.00%)		67.19
(89.30%)		📈 view plot
🚷 view threshold		371.00
(+0.26%)		381.34
(97.29%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,472.00
(-0.00%)		126,894.45
(99.67%)		📈 view plot
🚷 view threshold		73,117.00
(-0.22%)		73,532.23
(99.44%)		📈 view plot
🚷 view threshold		104,757.00
(-0.28%)		105,480.72
(99.31%)		📈 view plot
🚷 view threshold		115.00
(+7.97%)		129.70
(88.67%)		📈 view plot
🚷 view threshold		604.00
(+1.19%)		607.05
(99.50%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,848.00
(-0.04%)		28,573.28
(97.46%)		📈 view plot
🚷 view threshold		9,580.00
(-0.68%)		9,760.34
(98.15%)		📈 view plot
🚷 view threshold		13,518.00
(-0.90%)		13,825.01
(97.78%)		📈 view plot
🚷 view threshold		73.00
(+14.72%)		76.44
(95.50%)		📈 view plot
🚷 view threshold		399.00
(+0.46%)		416.02
(95.91%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,185.00
(-0.06%)		115,782.78
(99.48%)		📈 view plot
🚷 view threshold		67,894.00
(-0.30%)		68,419.52
(99.23%)		📈 view plot
🚷 view threshold		97,355.00
(-0.38%)		98,272.56
(99.07%)		📈 view plot
🚷 view threshold		73.00
(+15.87%)		80.26
(90.95%)		📈 view plot
🚷 view threshold		499.00
(+1.45%)		500.77
(99.65%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,209.00
(-0.31%)		23,949.96
(96.91%)		📈 view plot
🚷 view threshold		8,132.00
(-0.84%)		8,317.06
(97.77%)		📈 view plot
🚷 view threshold		11,429.00
(-1.05%)		11,733.33
(97.41%)		📈 view plot
🚷 view threshold		39.00
(+4.35%)		44.98
(86.70%)		📈 view plot
🚷 view threshold		331.00
(+0.35%)		346.68
(95.48%)
serialize_submit📈 view plot
🚷 view threshold		99,758.00
(-0.09%)		100,298.61
(99.46%)		📈 view plot
🚷 view threshold		61,328.00
(-0.27%)		61,745.40
(99.32%)		📈 view plot
🚷 view threshold		87,933.00
(-0.34%)		88,649.73
(99.19%)		📈 view plot
🚷 view threshold		55.00
(+17.57%)		64.72
(84.98%)		📈 view plot
🚷 view threshold		330.00
(+1.51%)		335.23
(98.44%)
serialize_subscribe📈 view plot
🚷 view threshold		11,383.00
(-0.22%)		11,677.87
(97.47%)		📈 view plot
🚷 view threshold		4,114.00
(-1.54%)		4,289.14
(95.92%)		📈 view plot
🚷 view threshold		5,693.00
(-2.03%)		5,992.05
(95.01%)		📈 view plot
🚷 view threshold		18.00
(+38.54%)		21.58
(83.39%)		📈 view plot
🚷 view threshold		160.00
(+1.22%)		163.68
(97.75%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.30%. Comparing base (b32485d) to head (756c9d7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
roles/jd-client/src/lib/upstream_sv2/upstream.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1281   +/-   ##
=======================================
  Coverage   19.30%   19.30%           
=======================================
  Files         164      164           
  Lines       10849    10849           
=======================================
  Hits         2094     2094           
  Misses       8755     8755
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <0.00%> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.49% <ø> (-0.02%) ⬇️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.55% <0.00%> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash plebhash mentioned this pull request Dec 10, 2024
Open
@plebhash plebhash merged commit 04caafb into stratum-mining:main Dec 10, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavlenex @plebhash