Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sv2-mining-proxy lib #1252

Merged
merged 2 commits into from
Dec 17, 2024
Merged

sv2-mining-proxy lib #1252

merged 2 commits into from
Dec 17, 2024

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Nov 14, 2024

resolves #1251

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (e07e045) to head (90bbb00).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   19.30%   19.29%   -0.01%     
==========================================
  Files         164      164              
  Lines       10849    10852       +3     
==========================================
  Hits         2094     2094              
- Misses       8755     8758       +3
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (-0.01%) ⬇️
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (-0.01%) ⬇️
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,133.00
(+1.29%)		2,219.76
(96.09%)		📈 view plot
🚷 view threshold		473.00
(-0.06%)		489.01
(96.73%)		📈 view plot
🚷 view threshold		733.00
(-0.36%)		757.99
(96.70%)		📈 view plot
🚷 view threshold		7.00
(+34.94%)		13.23
(52.91%)		📈 view plot
🚷 view threshold		39.00
(+1.55%)		41.45
(94.10%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,272.00
(+0.68%)		8,365.17
(98.89%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,157.00
(-0.10%)		3,171.11
(99.55%)		📈 view plot
🚷 view threshold		36.00
(+1.63%)		41.41
(86.93%)		📈 view plot
🚷 view threshold		141.00
(+1.14%)		143.53
(98.24%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,281.00
(-0.22%)		6,435.31
(97.60%)		📈 view plot
🚷 view threshold		1,750.00
(-0.05%)		1,767.36
(99.02%)		📈 view plot
🚷 view threshold		2,551.00
(-0.06%)		2,576.12
(99.02%)		📈 view plot
🚷 view threshold		18.00
(+5.59%)		24.35
(73.92%)		📈 view plot
🚷 view threshold		104.00
(-0.47%)		108.40
(95.94%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,744.00
(+0.13%)		14,940.75
(98.68%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.36
(99.63%)		📈 view plot
🚷 view threshold		6,749.00
(-0.13%)		6,785.80
(99.46%)		📈 view plot
🚷 view threshold		52.00
(+17.33%)		58.32
(89.16%)		📈 view plot
🚷 view threshold		221.00
(-0.13%)		226.77
(97.46%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,724.00
(+0.57%)		27,951.16
(99.19%)		📈 view plot
🚷 view threshold		10,645.00
(+0.44%)		10,675.96
(99.71%)		📈 view plot
🚷 view threshold		15,504.00
(+0.51%)		15,556.92
(99.66%)		📈 view plot
🚷 view threshold		92.00
(+11.79%)		94.55
(97.31%)		📈 view plot
🚷 view threshold		336.00
(+0.24%)		342.12
(98.21%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,447.00
(+1.40%)		4,544.47
(97.86%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,477.01
(98.92%)		📈 view plot
🚷 view threshold		2,157.00
(-0.16%)		2,183.69
(98.78%)		📈 view plot
🚷 view threshold		10.00
(+20.64%)		14.66
(68.20%)		📈 view plot
🚷 view threshold		64.00
(+2.58%)		66.93
(95.63%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,032.00
(+0.09%)		14,207.97
(98.76%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,080.01
(99.68%)		📈 view plot
🚷 view threshold		7,322.00
(-0.06%)		7,351.22
(99.60%)		📈 view plot
🚷 view threshold		40.00
(+12.70%)		45.35
(88.20%)		📈 view plot
🚷 view threshold		186.00
(-0.07%)		191.63
(97.06%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,816.00
(+0.62%)		22,963.01
(99.36%)		📈 view plot
🚷 view threshold		8,040.00
(+0.13%)		8,054.49
(99.82%)		📈 view plot
🚷 view threshold		11,691.00
(+0.08%)		11,715.07
(99.79%)		📈 view plot
🚷 view threshold		83.00
(+10.91%)		86.31
(96.16%)		📈 view plot
🚷 view threshold		306.00
(+0.86%)		310.58
(98.53%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,673.00
(-0.27%)		4,784.31
(97.67%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,518.01
(98.95%)		📈 view plot
🚷 view threshold		2,278.00
(-0.01%)		2,299.51
(99.06%)		📈 view plot
🚷 view threshold		10.00
(+3.31%)		16.47
(60.73%)		📈 view plot
🚷 view threshold		67.00
(-0.60%)		70.04
(95.67%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,188.00
(+0.25%)		16,314.46
(99.22%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,979.01
(99.73%)		📈 view plot
🚷 view threshold		8,653.00
(-0.13%)		8,691.48
(99.56%)		📈 view plot
🚷 view threshold		51.00
(+27.52%)		54.08
(94.31%)		📈 view plot
🚷 view threshold		208.00
(-0.05%)		212.28
(97.99%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,710.00
(+0.39%)		35,856.21
(99.59%)		📈 view plot
🚷 view threshold		14,888.00
(+0.18%)		14,907.61
(99.87%)		📈 view plot
🚷 view threshold		21,870.00
(+0.16%)		21,907.18
(99.83%)		📈 view plot
🚷 view threshold		108.00
(+16.98%)		112.23
(96.23%)		📈 view plot
🚷 view threshold		380.00
(+0.20%)		384.83
(98.75%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,580.30
(-0.55%)		7,059.43
(93.21%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,441.60
(-0.39%)		8,019.31
(92.80%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,080.50
(-0.12%)		8,511.81
(94.93%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		881.47
(+2.01%)		919.83
(95.83%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		683.55
(+1.78%)		706.68
(96.73%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		252.86
(+1.71%)		269.60
(93.79%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		157.06
(+0.10%)		163.98
(95.78%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,351.20
(-0.90%)		7,021.74
(90.45%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		276.59
(-1.32%)		304.56
(90.82%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		726.50
(+0.16%)		763.84
(95.11%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		580.71
(-1.07%)		616.00
(94.27%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		205.31
(-0.23%)		216.54
(94.81%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,448.00
(-0.15%)		8,680.93
(97.32%)		📈 view plot
🚷 view threshold		3,663.00
(-2.01%)		3,862.85
(94.83%)		📈 view plot
🚷 view threshold		5,108.00
(-2.46%)		5,448.66
(93.75%)		📈 view plot
🚷 view threshold		10.00
(+29.55%)		15.00
(66.66%)		📈 view plot
🚷 view threshold		94.00
(+3.31%)		95.82
(98.11%)
get_submit📈 view plot
🚷 view threshold		95,324.00
(-0.08%)		95,776.52
(99.53%)		📈 view plot
🚷 view threshold		59,263.00
(-0.29%)		59,714.99
(99.24%)		📈 view plot
🚷 view threshold		85,074.00
(-0.33%)		85,828.18
(99.12%)		📈 view plot
🚷 view threshold		48.00
(+8.72%)		58.98
(81.39%)		📈 view plot
🚷 view threshold		286.00
(+1.97%)		290.27
(98.53%)
get_subscribe📈 view plot
🚷 view threshold		7,919.00
(-1.16%)		8,234.58
(96.17%)		📈 view plot
🚷 view threshold		2,758.00
(-2.37%)		2,941.11
(93.77%)		📈 view plot
🚷 view threshold		3,834.00
(-2.80%)		4,139.71
(92.62%)		📈 view plot
🚷 view threshold		12.00
(+1.99%)		19.28
(62.25%)		📈 view plot
🚷 view threshold		115.00
(+0.41%)		117.76
(97.66%)
serialize_authorize📈 view plot
🚷 view threshold		12,237.00
(-0.31%)		12,514.29
(97.78%)		📈 view plot
🚷 view threshold		5,240.00
(-1.33%)		5,427.74
(96.54%)		📈 view plot
🚷 view threshold		7,277.00
(-1.67%)		7,604.06
(95.70%)		📈 view plot
🚷 view threshold		12.00
(+25.49%)		17.99
(66.69%)		📈 view plot
🚷 view threshold		140.00
(+1.53%)		142.12
(98.50%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,602.00
(-0.44%)		25,182.13
(97.70%)		📈 view plot
🚷 view threshold		9,786.00
(-0.90%)		10,032.22
(97.55%)		📈 view plot
🚷 view threshold		13,787.00
(-1.08%)		14,199.17
(97.10%)		📈 view plot
🚷 view threshold		35.00
(-0.13%)		45.13
(77.55%)		📈 view plot
🚷 view threshold		304.00
(+0.41%)		313.53
(96.96%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,219.00
(-0.37%)		30,708.61
(98.41%)		📈 view plot
🚷 view threshold		11,989.00
(-0.64%)		12,201.53
(98.26%)		📈 view plot
🚷 view threshold		16,954.00
(-0.77%)		17,309.23
(97.95%)		📈 view plot
🚷 view threshold		56.00
(+0.99%)		66.81
(83.82%)		📈 view plot
🚷 view threshold		371.00
(+0.13%)		379.61
(97.73%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,452.00
(-0.02%)		126,783.46
(99.74%)		📈 view plot
🚷 view threshold		73,117.00
(-0.21%)		73,522.17
(99.45%)		📈 view plot
🚷 view threshold		104,762.00
(-0.26%)		105,483.69
(99.32%)		📈 view plot
🚷 view threshold		110.00
(+4.12%)		123.69
(88.93%)		📈 view plot
🚷 view threshold		604.00
(+1.10%)		607.30
(99.46%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,829.00
(-0.22%)		28,462.07
(97.78%)		📈 view plot
🚷 view threshold		9,577.00
(-0.67%)		9,753.78
(98.19%)		📈 view plot
🚷 view threshold		13,519.00
(-0.84%)		13,826.56
(97.78%)		📈 view plot
🚷 view threshold		69.00
(+8.46%)		76.07
(90.71%)		📈 view plot
🚷 view threshold		399.00
(+0.18%)		412.56
(96.71%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,181.00
(-0.06%)		115,733.32
(99.52%)		📈 view plot
🚷 view threshold		67,894.00
(-0.28%)		68,419.66
(99.23%)		📈 view plot
🚷 view threshold		97,356.00
(-0.35%)		98,283.55
(99.06%)		📈 view plot
🚷 view threshold		72.00
(+13.51%)		82.89
(86.86%)		📈 view plot
🚷 view threshold		499.00
(+1.30%)		500.66
(99.67%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,202.00
(-0.45%)		23,863.84
(97.23%)		📈 view plot
🚷 view threshold		8,129.00
(-0.82%)		8,310.67
(97.81%)		📈 view plot
🚷 view threshold		11,427.00
(-0.99%)		11,735.06
(97.37%)		📈 view plot
🚷 view threshold		38.00
(+0.52%)		47.97
(79.22%)		📈 view plot
🚷 view threshold		331.00
(+0.07%)		344.12
(96.19%)
serialize_submit📈 view plot
🚷 view threshold		99,789.00
(-0.03%)		100,212.66
(99.58%)		📈 view plot
🚷 view threshold		61,325.00
(-0.25%)		61,741.97
(99.32%)		📈 view plot
🚷 view threshold		87,929.00
(-0.31%)		88,657.08
(99.18%)		📈 view plot
🚷 view threshold		55.00
(+17.65%)		64.04
(85.88%)		📈 view plot
🚷 view threshold		331.00
(+1.77%)		335.52
(98.65%)
serialize_subscribe📈 view plot
🚷 view threshold		11,402.00
(-0.06%)		11,617.40
(98.15%)		📈 view plot
🚷 view threshold		4,111.00
(-1.49%)		4,281.57
(96.02%)		📈 view plot
🚷 view threshold		5,692.00
(-1.89%)		5,992.28
(94.99%)		📈 view plot
🚷 view threshold		15.00
(+15.32%)		21.57
(69.53%)		📈 view plot
🚷 view threshold		161.00
(+1.68%)		163.45
(98.50%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-11-14-mining-proxy-lib
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.83
(+0.70%)		46.71
(95.98%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		78.29
(+0.46%)		103.32
(75.78%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.67
(+0.06%)		14.70
(99.78%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		261.36
(-1.81%)		294.80
(88.66%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		606.98
(-1.04%)		650.63
(93.29%)
client_sv2_open_channel📈 view plot
🚷 view threshold		164.43
(-0.04%)		174.51
(94.22%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		289.95
(+1.85%)		310.33
(93.43%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		376.15
(-1.95%)		413.65
(90.94%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		161.17
(+0.52%)		171.90
(93.76%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		468.25
(-0.77%)		557.88
(83.93%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		979.23
(-1.69%)		1,080.30
(90.64%)
🐰 View full continuous benchmarking report in Bencher

@plebhash plebhash mentioned this pull request Nov 15, 2024
Merged
@jbesraa jbesraa force-pushed the 2024-11-14-mining-proxy-lib branch from 65812ef to b1c265a Compare December 16, 2024 10:37
@jbesraa jbesraa marked this pull request as ready for review December 16, 2024 10:38
@jbesraa jbesraa force-pushed the 2024-11-14-mining-proxy-lib branch from b1c265a to 78d203b Compare December 16, 2024 10:56
Shourya742
Shourya742 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 78d203b

@jbesraa jbesraa force-pushed the 2024-11-14-mining-proxy-lib branch from 78d203b to 90bbb00 Compare December 17, 2024 16:24
@jbesraa
Copy link
Contributor Author

jbesraa commented Dec 17, 2024

Rebased without further changes

@plebhash plebhash merged commit e042650 into stratum-mining:main Dec 17, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shourya742 Shourya742 Shourya742 approved these changes

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create lib for sv2-mining-proxy
4 participants
@jbesraa @GitGab19 @Shourya742 @plebhash