Utils buffer sv2 docs #1232
Merged
Utils buffer sv2 docs #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrybarczyk
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
=======================================
Coverage 19.30% 19.30%
=======================================
Files 164 164
Lines 10849 10849
=======================================
Hits 2094 2094
Misses 8755 8755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bencher Report| Branch | 1232/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,137.00 | 📈 view plot | 473.00 | 📈 view plot | 732.00 | 📈 view plot | 8.00 | 📈 view plot | 39.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,204.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,159.00 | 📈 view plot | 36.00 | 📈 view plot | 139.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,327.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,547.00 | 📈 view plot | 21.00 | 📈 view plot | 105.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,712.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,757.00 | 📈 view plot | 44.00 | 📈 view plot | 221.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,522.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,397.00 | 📈 view plot | 87.00 | 📈 view plot | 334.00 |
| client_sv2_open_channel | 📈 view plot | 4,379.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,159.00 | 📈 view plot | 10.00 | 📈 view plot | 62.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,974.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,329.00 | 📈 view plot | 34.00 | 📈 view plot | 185.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,727.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,667.00 | 📈 view plot | 84.00 | 📈 view plot | 304.00 |
| client_sv2_setup_connection | 📈 view plot | 4,715.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,275.00 | 📈 view plot | 12.00 | 📈 view plot | 68.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,140.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,665.00 | 📈 view plot | 39.00 | 📈 view plot | 208.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,538.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,818.00 | 📈 view plot | 98.00 | 📈 view plot | 378.00 |
|
| Branch | 1232/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,383.00 | 📈 view plot | 3,689.00 | 📈 view plot | 5,158.00 | 📈 view plot | 8.00 | 📈 view plot | 91.00 |
| get_submit | 📈 view plot | 95,381.00 | 📈 view plot | 59,346.00 | 📈 view plot | 85,221.00 | 📈 view plot | 44.00 | 📈 view plot | 284.00 |
| get_subscribe | 📈 view plot | 7,876.00 | 📈 view plot | 2,765.00 | 📈 view plot | 3,846.00 | 📈 view plot | 15.00 | 📈 view plot | 113.00 |
| serialize_authorize | 📈 view plot | 12,210.00 | 📈 view plot | 5,266.00 | 📈 view plot | 7,325.00 | 📈 view plot | 11.00 | 📈 view plot | 138.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,306.00 | 📈 view plot | 9,838.00 | 📈 view plot | 13,891.00 | 📈 view plot | 32.00 | 📈 view plot | 293.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,016.00 | 📈 view plot | 12,015.00 | 📈 view plot | 17,001.00 | 📈 view plot | 62.00 | 📈 view plot | 363.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,279.00 | 📈 view plot | 73,200.00 | 📈 view plot | 104,914.00 | 📈 view plot | 108.00 | 📈 view plot | 595.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 27,392.00 | 📈 view plot | 9,584.00 | 📈 view plot | 13,547.00 | 📈 view plot | 67.00 | 📈 view plot | 386.00 |
| serialize_deserialize_submit | 📈 view plot | 115,049.00 | 📈 view plot | 68,060.00 | 📈 view plot | 97,659.00 | 📈 view plot | 62.00 | 📈 view plot | 488.00 |
| serialize_deserialize_subscribe | 📈 view plot | 22,820.00 | 📈 view plot | 8,143.00 | 📈 view plot | 11,465.00 | 📈 view plot | 38.00 | 📈 view plot | 319.00 |
| serialize_submit | 📈 view plot | 99,770.00 | 📈 view plot | 61,408.00 | 📈 view plot | 88,080.00 | 📈 view plot | 49.00 | 📈 view plot | 327.00 |
| serialize_subscribe | 📈 view plot | 11,321.00 | 📈 view plot | 4,118.00 | 📈 view plot | 5,706.00 | 📈 view plot | 17.00 | 📈 view plot | 158.00 |
|
| Branch | 1232/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.15 |
| client_sv2_handle_message_mining | 📈 view plot | 75.40 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.67 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 265.90 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 582.17 |
| client_sv2_open_channel | 📈 view plot | 149.11 |
| client_sv2_open_channel_serialize | 📈 view plot | 291.66 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 375.21 |
| client_sv2_setup_connection | 📈 view plot | 160.56 |
| client_sv2_setup_connection_serialize | 📈 view plot | 493.74 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 967.66 |
rrybarczyk
force-pushed
the
utils-buffer-sv2-docs
branch
7 times, most recently
from
bf95e9b to
d8c1798
Compare
rrybarczyk
commented
Oct 22, 2024
Shourya742
suggested changes
Oct 24, 2024
rrybarczyk
force-pushed
the
utils-buffer-sv2-docs
branch
5 times, most recently
from
74fc730 to
3137545
Compare
rrybarczyk
force-pushed
the
utils-buffer-sv2-docs
branch
3 times, most recently
from
db7a330 to
49ac424
Compare
rrybarczyk
force-pushed
the
utils-buffer-sv2-docs
branch
from
2bb576a to
49c3fb3
Compare
plebhash
reviewed
Dec 2, 2024
plebhash
reviewed
Dec 2, 2024
plebhash
reviewed
Dec 2, 2024
|
@rrybarczyk I guess I said on the last call that I felt this PR was ready, but after another look I left a few extra comments |
GitGab19
reviewed
Dec 2, 2024
rrybarczyk
force-pushed
the
utils-buffer-sv2-docs
branch
2 times, most recently
from
ce084cf to
f9a79e5
Compare
|
Alright, I just cleaned up many old comments from my last review. What I left there is something which is worth resolving/answering before proceeding @rrybarczyk |
rrybarczyk
force-pushed
the
utils-buffer-sv2-docs
branch
2 times, most recently
from
ec9e4fb to
1d95d86
Compare
rrybarczyk
force-pushed
the
utils-buffer-sv2-docs
branch
from
1d95d86 to
13ab37d
Compare
GitGab19
approved these changes
Dec 11, 2024
plebhash
approved these changes
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1184.