Skip to content

Commit

Permalink
add suggested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Shourya742 committed Jan 22, 2025
1 parent 9047933 commit 6f05a39
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions roles/jd-client/src/lib/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -371,11 +371,11 @@ impl JobDeclaratorClient {
.await;
}

/// Notifies the JD-Client to shut down gracefully.
/// Closes JDC role and any open connection associated with it.
///
/// This method triggers the shutdown process by sending a notification.
/// It ensures that any ongoing operations are properly handled before
/// the jd-client stops functioning.
/// Note that this method will result in a full exit of the running
/// jd-client and any open connection most be re-initiated upon new
/// start.
#[allow(dead_code)]
pub fn shutdown(&self) {
self.shutdown.notify_one();
Expand Down
8 changes: 4 additions & 4 deletions roles/translator/src/lib/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,11 @@ impl TranslatorSv2 {
task_collector.safe_lock(|t| t.push((task.abort_handle(), "init task".to_string())));
}

/// Notifies the translator to shut down gracefully.
/// Closes Translator role and any open connection associated with it.
///
/// This method triggers the shutdown process by sending a notification.
/// It ensures that any ongoing operations are properly handled before
/// the translator stops functioning.
/// Note that this method will result in a full exit of the running
/// Translator and any open connection most be re-initiated upon new
/// start.
pub fn shutdown(&self) {
self.shutdown.notify_last();
}
Expand Down

0 comments on commit 6f05a39

Please sign in to comment.