Skip to content

Commit

Permalink
avoid publishing protocols crates with all-features..
Browse files Browse the repository at this point in the history
publishing with all-features is overengineering:
- no_std is being deprecated
- with_serde will be deprecated soon
- for crates with relevant features, we specifically list them for publishing
  • Loading branch information
plebhash committed Jan 7, 2025
1 parent 651f35a commit 2e8e4fd
Show file tree
Hide file tree
Showing 15 changed files with 4 additions and 37 deletions.
2 changes: 1 addition & 1 deletion protocols/v2/binary-sv2/binary-sv2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ prop_test = ["binary_codec_sv2/prop_test", "derive_codec_sv2"]
with_buffer_pool = ["binary_codec_sv2/with_buffer_pool", "derive_codec_sv2"]

[package.metadata.docs.rs]
all-features = true
features = ["core", "with_buffer_pool"]
2 changes: 1 addition & 1 deletion protocols/v2/binary-sv2/no-serde-sv2/codec/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ prop_test = ["quickcheck"]
with_buffer_pool = ["buffer_sv2"]

[package.metadata.docs.rs]
all-features = true
features = ["with_buffer_pool"]
3 changes: 0 additions & 3 deletions protocols/v2/binary-sv2/no-serde-sv2/derive_codec/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,3 @@ binary_codec_sv2 = {version = "^1.0.0", path="../codec"}

[lib]
proc-macro = true

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions protocols/v2/binary-sv2/serde-sv2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,3 @@ keywords = ["stratum", "mining", "bitcoin", "protocol"]
[dependencies]
serde = { version = "1.0.89", features = ["derive", "alloc"], default-features = false }
buffer_sv2 = {version = "^1.0.0", path = "../../../../utils/buffer"}

[package.metadata.docs.rs]
all-features = true
2 changes: 1 addition & 1 deletion protocols/v2/codec-sv2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ with_buffer_pool = ["framing_sv2/with_buffer_pool"]
no_std = []

[package.metadata.docs.rs]
all-features = true
features = ["with_buffer_pool", "noise_sv2"]
3 changes: 0 additions & 3 deletions protocols/v2/const-sv2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,3 @@ homepage = "https://stratumprotocol.org"
keywords = ["stratum", "mining", "bitcoin", "protocol"]

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[package.metadata.docs.rs]
all-features = true
2 changes: 1 addition & 1 deletion protocols/v2/framing-sv2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ with_serde = ["binary_sv2/with_serde", "serde", "buffer_sv2?/with_serde"]
with_buffer_pool = ["binary_sv2/with_buffer_pool", "buffer_sv2"]

[package.metadata.docs.rs]
all-features = true
features = ["with_buffer_pool"]
3 changes: 0 additions & 3 deletions protocols/v2/noise-sv2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,3 @@ const_sv2 = { version = "^3.0.0", path = "../../../protocols/v2/const-sv2"}
[dev-dependencies]
quickcheck = "1.0.3"
quickcheck_macros = "1"

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions protocols/v2/roles-logic-sv2/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,3 @@ with_serde = [ "serde",
prop_test = ["template_distribution_sv2/prop_test"]
# Code coverage tools may conflict with the nopanic logic, so we can disable it when needed
disable_nopanic = []

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions protocols/v2/subprotocols/common-messages/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,3 @@ serde_repr = { version= "0.1.10", optional = true }
[features]
with_serde = ["binary_sv2/with_serde", "serde", "serde_repr"]
prop_test = ["quickcheck"]

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions protocols/v2/subprotocols/job-declaration/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,3 @@ const_sv2 = {version = "^3.0.0", path = "../../const-sv2"}

[features]
with_serde = ["binary_sv2/with_serde", "serde"]

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions protocols/v2/subprotocols/mining/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,3 @@ quickcheck_macros = "1"

[features]
with_serde = ["binary_sv2/with_serde", "serde"]

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions protocols/v2/subprotocols/template-distribution/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,3 @@ quickcheck_macros = { version = "1", optional=true }
[features]
with_serde = ["binary_sv2/with_serde", "serde"]
prop_test = ["quickcheck"]

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions protocols/v2/sv2-ffi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,3 @@ quickcheck_macros = "1"
[features]
with_serde = []
prop_test = ["binary_sv2/prop_test", "common_messages_sv2/prop_test", "template_distribution_sv2/prop_test"]

[package.metadata.docs.rs]
all-features = true
3 changes: 0 additions & 3 deletions utils/buffer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,3 @@ harness = false
debug = []
fuzz = []
with_serde = ["serde"]

[package.metadata.docs.rs]
all-features = true

0 comments on commit 2e8e4fd

Please sign in to comment.