Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow vite overwrites #15

Merged
merged 2 commits into from
Sep 12, 2024
Merged

chore: allow vite overwrites #15

merged 2 commits into from
Sep 12, 2024

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Sep 10, 2024

Allows vite overwrites for fine grained control from the plugin sdk

@alexandrebodin alexandrebodin added the pr: chore Cleanups / dependencies / tooling / styling label Sep 10, 2024
@alexandrebodin alexandrebodin self-assigned this Sep 10, 2024
Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 964dc85

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexandrebodin alexandrebodin force-pushed the chore/support-cjs branch 2 times, most recently from 703f8f6 to d0238c2 Compare September 11, 2024 15:21
@alexandrebodin alexandrebodin changed the title chore: support cjs in all sourcecode that is not external chore: allow vite overwrites Sep 11, 2024
@alexandrebodin alexandrebodin marked this pull request as ready for review September 11, 2024 15:22
@alexandrebodin
Copy link
Member Author

Released under 0.0.0-experimental.d0238c20f2d2af79a77b594f297c7380a46dfe33 for testing

innerdvations
innerdvations previously approved these changes Sep 12, 2024
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me!

@alexandrebodin alexandrebodin merged commit f2cf2d6 into main Sep 12, 2024
3 checks passed
@alexandrebodin alexandrebodin deleted the chore/support-cjs branch September 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore Cleanups / dependencies / tooling / styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants