-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: WPBakery Compatibility #2585
base: dev
Are you sure you want to change the base?
Conversation
…rding improvements; do not protect content in the editor context.
@JarrydLong did some adjusting here - I am up in the air on if this is complete enough to merge in. Its strange how WP Bakery works that you have to basically rewrite their "shortcodes" / component like this. Makes me worry if a theme is doing this, it wouldn't work for the membership site. But if people are asking for this, it is working now. I adjusted some things here and also added a bail if in the context of the live editor so admins can build with this in the editing experience without content getting restricted. Give me a thumbs up or down on if you think we should hold this back to 3.1 or go for it now. |
I think it works well for an MVP but maybe leave it for 3.1. Extending it to support other fields is quite easy which we can do (doesn't even need to be in a cycle) and have everything align with the other page builder integrations |
…ships-pro into pr/JarrydLong/2585
All Submissions:
Changes proposed in this Pull Request:
Implements compatibility support for the WP Bakery Page Builder
How to test the changes in this Pull Request:
Other information: