Move € symbol to the left for de_* locales

[mircobabini]

All Submissions:

• Have you followed the Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Resolves #1473.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you successfully run tests with your changes locally?

[ideadude]

I noticed the current rules here (http://publications.europa.eu/code/en/en-370303.htm) state:

Position of the euro sign (€) in amounts
The euro sign is followed by the amount without space:
a sum of €30
NB: The same rule applies in Dutch, Irish and Maltese. In all other official EU languages the order is reversed; the amount is followed by a hard space and the euro sign:
une somme de 30 €

However, Amazon.de has the euro symbol showing up after the amount. I'd really like there to be a consensus when I make changes like this, otherwise people will reach out and want the symbol on the OTHER SIDE again.

I don't know how we should define consensus. It would be nice if we could outsource these decisions and piggy back on the decisions of a larger open source project like WooCommerce or even a non-WP project that deals with currencies.

Any ideas?

[mircobabini]

Nice job. I think we followed the same path (Quora > Wikipedia > European Union Commission). By the way, seems like the logic follows the old currency active before the euro introduction which is relatively new.

At this point, I totally agree. Was out of knowledge about this, just thought it was a bug but it's not. Woocommerce should let the user choose where to put the currency symbol as far as I know; but really don't know how the multi-currency feature works. I'll check it out soon.

I just found something very interesting.

1. Everyone is saying that the $ sign must be before the value.
2. Just found a guy telling that in canada, you put the $ sign after the value.
3. Looking deeper I found this FastSpring article and I think this one is pretty much like a bible... just because this is what they do.

Canada does it both ways. In English Canada, the dollar symbol goes to the left of the amount, while in French Canada, the dollar sign goes to the right.

By the way, code talking now. This pull request is just to follow the same code-style of what was already implemented into PMPro, but since there is no real solid logic in place, I think we should switch to something more solid first.

Maybe we can just work on global $pmpro_currencies (just thinking out loud). Let's take the Canada example above. Can we add that logic in that structure? Maybe we should use the locales instead of the currency ISO 4217 code.

I'll make some other research. Speak soon.

[mircobabini]

WooCommerce settings:
=> can just set a global value for all currencies

Multi Currency for WooCommerce (the best, they say):
=> foreach currency, same settings as above

Another multi-currency:
=> same as above

Can't find a very complete solution. I think that we should:

1. Define standards for most diffused currencies
2. Define overrides for well known specific countries differences ($ for Canada, EUR for Dutch, Irish and Maltese)

These filterable overrides should be locale-based.

[sc0ttkclark]

@ideadude Did we sort out a solution for this?