Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Euro currency position for Deutsch locale #1473

Open
kimcoleman opened this issue Sep 9, 2020 · 1 comment · May be fixed by #1502
Open

Euro currency position for Deutsch locale #1473

kimcoleman opened this issue Sep 9, 2020 · 1 comment · May be fixed by #1502
Labels
Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help. Status: Code Review Type: Enhancement
Milestone
Backlog

Comments

@kimcoleman
Copy link
Member

Describe the bug
A user has suggested that the location of the currency symbol for the Euro when using the Deutsch locale should be on the left. The function pmpro_euro_position_from_locale could be extended to support this locale and currency position.

https://github.com/strangerstudios/paid-memberships-pro/blob/dev/includes/currencies.php#L119-L129
@kimcoleman kimcoleman added the Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help. label Sep 9, 2020
@mircobabini mircobabini linked a pull request Nov 8, 2020 that will close this issue
Draft
5 tasks
@mircobabini
Copy link
Member

Just followed the same login already implemented for the en_ locales.

Maybe a switch(true) would be cleaner but I don't like weird usage of switch/case.

switch(true):
    case strpos(...):
    case strpos(...):
        $position = 'left';

@sc0ttkclark sc0ttkclark added this to the Backlog milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help. Status: Code Review Type: Enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Move € symbol to the left for de_* locales
4 participants
@mircobabini @sc0ttkclark @kimcoleman @dparker1005