chore(wormchain): wormhole module testing #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelsmith-2019
requested review from
nik-suri,
johnsaigle and
mdulin2
as code owners
jtieri
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
During our live coding review session we walked through all the changes and determined that testing coverage has definitely improved, the testing logic all makes sense, and the changes look good.
Had the two comments but nothing major, going to approve so merging isnt blocked.
pharr117
approved these changes
Sep 19, 2024
joelsmith-2019
merged commit 7887299
into
joel/wormchain-v0.47.12
22 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25