Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gameObject): move / remove dom nodes when add / remove children #397

Closed
wants to merge 2 commits into from

Conversation

straker
Copy link
Owner

@straker straker commented Apr 17, 2024

Decided not to make the property public and instead make the GameObject addChild and removeChild functions do the moving. That way I don't need to remove the HTML obfuscation.

Closes #365

@straker
Copy link
Owner Author

straker commented Apr 17, 2024

This won't work as expected if creating complex DOM setups, like a table or grid, where there's an intermediate HTML node like a tr or div. For those case the DOM node really needs to be public to append it to the correct HTML element (and not the GameObject element)

@straker straker closed this Apr 17, 2024
@straker straker deleted the dom-nodes branch April 20, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dom nodes public
1 participant