fix(gameLoop): emit tick event every update

straker · Apr 6, 2024 · d3da95a · d3da95a
1 parent 885af01
commit d3da95a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/gameLoop.js b/src/gameLoop.js
@@ -110,10 +110,10 @@ export default function GameLoop({
       return;
     }
 
-    emit('tick');
     accumulator += dt;
 
     while (accumulator >= delta) {
+      emit('tick');
       loop.update(step);
 
       accumulator -= delta;

diff --git a/test/unit/gameLoop.spec.js b/test/unit/gameLoop.spec.js
@@ -270,6 +270,19 @@ describe('gameLoop', () => {
       expect(spy.called).to.be.true;
     });
 
+    it('should emit the tick event for each loop update', () => {
+      let spy = sinon.spy();
+      on('tick', spy);
+
+      loop = GameLoop({
+        render: noop
+      });
+      loop._last = performance.now() - 2001 / 60;
+      loop._frame();
+
+      expect(spy.calledTwice).to.be.true;
+    });
+
     it('should not update if page is blurred', done => {
       loop = GameLoop({
         update() {