Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expiration restriction to royalty payments #91

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Add expiration restriction to royalty payments #91

merged 2 commits into from
Apr 15, 2024

Conversation

Spablob
Copy link

@Spablob Spablob commented Apr 14, 2024 •
edited
Loading

Makes royalty payments revert if the ip is expired.

This change is part of the issue #68.

LeoHChen
LeoHChen reviewed Apr 14, 2024
View reviewed changes
Copy link

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass

contracts/modules/royalty/RoyaltyModule.sol Show resolved Hide resolved
contracts/modules/royalty/RoyaltyModule.sol Outdated Show resolved Hide resolved
jdubpark
jdubpark approved these changes Apr 14, 2024
View reviewed changes
Copy link

@jdubpark jdubpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that RoyaltyModule, we are making Dispute Module and License Registry addresses immutable, while some other contracts have setters.

@LeoHChen
Copy link

Noting that RoyaltyModule, we are making Dispute Module and License Registry addresses immutable, while some other contracts have setters.

Do we need to unify them?

@LeoHChen
Copy link

Merge conflict, please rebase code

@LeoHChen LeoHChen merged commit 67ca7dd into storyprotocol:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdubpark jdubpark jdubpark approved these changes

@LeoHChen LeoHChen LeoHChen approved these changes

@kingster-will kingster-will Awaiting requested review from kingster-will kingster-will is a code owner

@Ramarti Ramarti Awaiting requested review from Ramarti

@leeren leeren Awaiting requested review from leeren

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spablob @LeoHChen @jdubpark