-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Permissionless IP Registration #9
Implement Permissionless IP Registration #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, the overall logic looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a few comments
Will your next PR remove the keyword "Permissionless" (in the codebase) and make it just "IPRegistered"? |
fb9a935
to
691080d
Compare
Correct, it was mentioned in the code comments and the PR description. |
@jdubpark needs to approve it before I can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces an enhancement to the IP registration process within the Story Protocol by implementing permissionless IP registration. With this update, the IPAssetRegistry now automatically retrieves the required metadata ("name" and "tokenURI") from the IP NFT, eliminating the need for registrants or callers to provide this metadata manually.
It allows anyone can register IP for any NFT permissionlessly.
Additionally, IPAccounts are deployed automatically during the IP registration process, with metadata being stored directly into the IPAccount. This simplification not only streamlines the registration process but also reduces the gas costs on-board IPs into the Story Protocol.
It's important to note that while this PR enables permissionless IP registration, it does not remove the existing permissioned IP registration-related functions. The cleanup of these functions will be handled in the next PR.
Key Changes