Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Permissionless IP Registration #9

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

kingster-will
Copy link

This PR introduces an enhancement to the IP registration process within the Story Protocol by implementing permissionless IP registration. With this update, the IPAssetRegistry now automatically retrieves the required metadata ("name" and "tokenURI") from the IP NFT, eliminating the need for registrants or callers to provide this metadata manually.
It allows anyone can register IP for any NFT permissionlessly.

Additionally, IPAccounts are deployed automatically during the IP registration process, with metadata being stored directly into the IPAccount. This simplification not only streamlines the registration process but also reduces the gas costs on-board IPs into the Story Protocol.

It's important to note that while this PR enables permissionless IP registration, it does not remove the existing permissioned IP registration-related functions. The cleanup of these functions will be handled in the next PR.

Key Changes

  1. Automatic Metadata Retrieval: The IPAssetRegistry now automatically fetches "name" and "tokenURI" from the IP NFT during registration.
  2. Automatic IPAccount Deployment: IPAccounts are now automatically deployed during the IP registration process, with the fetched metadata being stored directly.
  3. Simplified Registration Process: The updates simplify the IP registration process, making it more accessible and reducing gas costs.
  4. 100% Test Coverage: Ensured that all new code paths introduced by PR are fully covered by tests.

@kingster-will kingster-will self-assigned this Mar 19, 2024
@jdubpark jdubpark self-requested a review March 19, 2024 17:32
Copy link

@jdubpark jdubpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, the overall logic looks good.

@jdubpark jdubpark self-requested a review March 20, 2024 00:16
@kingster-will kingster-will requested a review from LeoHChen March 20, 2024 19:07
Copy link
Member

@LeoHChen LeoHChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a few comments

@jdubpark
Copy link

Will your next PR remove the keyword "Permissionless" (in the codebase) and make it just "IPRegistered"?

@kingster-will kingster-will force-pushed the v1/permissionless-ip-reg branch from fb9a935 to 691080d Compare March 21, 2024 21:46
@kingster-will
Copy link
Author

Will your next PR remove the keyword "Permissionless" (in the codebase) and make it just "IPRegistered"?

Correct, it was mentioned in the code comments and the PR description.

@LeoHChen
Copy link
Member

@jdubpark needs to approve it before I can merge.

Copy link

@jdubpark jdubpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoHChen LeoHChen merged commit ee44018 into storyprotocol:main Mar 21, 2024
1 check passed
@kingster-will kingster-will deleted the v1/permissionless-ip-reg branch March 21, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants