Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradeable IpAssetRegistry #74

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

Ramarti
Copy link

@Ramarti Ramarti commented Apr 12, 2024

Refactor to make IPAssetRegistry upgradeable

@Ramarti Ramarti force-pushed the upgradeable_ipassetregistry branch from b020807 to 20b78ec Compare April 12, 2024 23:32
Copy link

@jdubpark jdubpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: some zero address reverts are placed after some upgrade init (just code uniformity)

@LeoHChen LeoHChen merged commit 514a2a1 into storyprotocol:main Apr 13, 2024
3 checks passed
jdubpark pushed a commit to jdubpark/sp-protocol-core that referenced this pull request Apr 14, 2024
* upgradeable ip asset registry

* deploy script setTargetFunctionRole
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants