Add Cross-Chain IP Registration Functionality #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
Ramarti,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
jdubpark
reviewed
Apr 11, 2024
LeoHChen
reviewed
Apr 11, 2024
|
The decision is to support cross chain mint in register with chain id added for now. |
kingster-will
force-pushed
the
v1/chainid-registration
branch
from
d12f035 to
67b3f0c
Compare
LeoHChen
approved these changes
Apr 14, 2024
jdubpark
approved these changes
Apr 14, 2024
jdubpark
pushed a commit
to jdubpark/sp-protocol-core
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new function to the
IPAssetRegistrycontract that allows for the registration of IP NFTs from different chain.The new function,
registerCrossChain, takes in three parameters:chainId,tokenContract, andtokenId. ThechainIdrepresents the identifier of the blockchain network where the IP NFT resides.This function first checks if the
chainIdis the same as the current network'schainId. If they are the same, it throws an error as this function is specifically designed for cross-chain registrations.