New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused Mocks #52

Merged

LeoHChen merged 1 commit into storyprotocol:main from jdubpark:test-remove-mocks

Apr 10, 2024

jdubpark commented Apr 10, 2024 •

edited

Loading

Remove unused mocks in the test folder.

We still have many mock modules that I'm not too familiar with, @kingster-will has used these

MockAccessControlledModule.sol
MockAllMetadataViewModule.sol
MockCoreMetadataViewModule.sol
MockMetadataModule.sol
MockMetaTxModule.sol
MockModule.sol
MockOrchestratorModule.sol
CustomModuleType.sol

The rationale for keeping other mock contracts:

MockRoyaltyPolicyLAP.sol is used for license-related tests where we want to test just the license system
MockERC20.sol, MockERC721.sol, MockERC721WithoutMetadata.sol, and MockERC1155.sol are needed for tokens
MockTokenGatedHook.sol needed for testing PIL terms commercializer checker


          refactor: remove unused mocks

6bcf09f

jdubpark requested review from kingster-will, Ramarti, leeren, Spablob, LeoHChen and AndyBoWu as code owners

April 10, 2024 17:47

kingster-will approved these changes

View reviewed changes

LeoHChen approved these changes

View reviewed changes

LeoHChen merged commit f652976 into storyprotocol:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kingster-will kingster-will approved these changes

LeoHChen LeoHChen approved these changes

Ramarti Awaiting requested review from Ramarti

leeren Awaiting requested review from leeren

Spablob Awaiting requested review from Spablob Spablob is a code owner

AndyBoWu Awaiting requested review from AndyBoWu

Labels

None yet