-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Licensing with New Features and Simplified Data Structure #33
Refactor Licensing with New Features and Simplified Data Structure #33
Conversation
I think we should name this a V1 for the mainnet release (or no suffix, still indicates first version) and deprecate the old LicenseRegistry and LicensingModule. |
Yes, this is a temporary name, for easier testing. will rename and remove the "V2" after fully reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go over current comments and add Natspec.
This is a big PR, more context is needed for a second review pass on the actual logic.
Thanks
contracts/modules/licensing/parameter-helpers/LicensorApprovalCheckerV2.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done first review, lots of code and need to compare with previous version to make sure business logic are the same. Also needs extensive usecase testing to make sure there is no regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get a 2nd pass, add a few more review comments.
ef90458
to
15b0b9c
Compare
contracts/modules/licensing/parameter-helpers/LicensorApprovalChecker.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor comments
Re-enable all protocol tests disabled in PR #33 by integrating the new license system into existing tests. Additionally, it removes all the PIL Policy Framework tests as the structure of the PIL and license system has changed significantly. We will require more tests for the new PILicenseTemplate that closely reflects the previous test cases of the PIL Policy Framework.
This PR introduces significant updates to our licensing mechanism, focusing on both refactoring the existing codebase and adding new, highly requested features. Below is a detailed breakdown of the enhancements and refactorings included in this PR.
Refactorings:
LicenseTemplate
: We've abstracted common licensing properties and behaviors into a newLicenseTemplate
.New Features: