Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Licensing Config to Only Increase Royalty Percentage #310

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

kingster-will
Copy link

Description

This PR adds a check to ensure that the licensingConfig can only increase the royalty percentage compared to the royalty percentage defined in the license terms. This prevents child IPs from overriding parent IPs' royalty percentages with unreasonably low percentages, maintaining fair royalty distribution.

Key Changes

  • Royalty Percentage Check: Added logic to verify that the new royalty percentage in licensingConfig is not lower than the royalty percentage defined in the license terms.

Copy link
Member

@sebsadface sebsadface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kingster-will kingster-will merged commit 0537c86 into storyprotocol:main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants