Prevent Child IP from Linking to More Parent IPs More than Once #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
Ramarti,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
|
I'd suggest changing the title to "Prevent Child IP from Linking to Parent More than Once" since some IPs will register and then add parents in the future (first time). This PR just prevents adding parents more than once in the future. |
kingster-will
changed the title
Spablob
reviewed
Mar 28, 2024
LeoHChen
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that a child IP cannot link to more parent IPs again. Added validation logic in the IP linking function to check if the child IP is already associated with a parent IP. If so, the operation is aborted, and an error message is returned.