Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying IP Registration and Metadata Management in Story Protocol #17

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

kingster-will
Copy link

This PR introduces significant changes aimed at simplifying the IP registration process and the handling of metadata within the protocol. By focusing on permissionless IP registration and removing complex metadata components, we've made the system more accessible and reduced the overall complexity of the codebase.

Key Changes:

Cleanup of Permissioned IP Registration Code Path

  • Removed Permissioned Registration: All code related to permissioned IP registration has been removed, leaving only the permissionless IP registration mechanism. This change simplifies the registration process and aligns with our goal of making the protocol more open.

Simplification of Metadata Handling

  • Metadata Components Removal: The metadata provider, version migration, resolver, and renderer components have been removed. This decision was made to streamline the process of managing IP metadata, reducing the need for multiple layers of complexity.

These changes collectively enhance the protocol by making IP registration more accessible and simplifying the management of metadata. By removing unnecessary components and focusing on a streamlined approach, we've made the system more efficient and easier to maintain.

@LeoHChen
Copy link
Member

Is this one depending on the new storage ?

@kingster-will kingster-will force-pushed the v1/cleanup-registration branch from 8fc4e78 to 47388c4 Compare March 24, 2024 17:05
@kingster-will
Copy link
Author

Is this one depending on the new storage ?

The PR doesn’t depend on the new storage; this PR just cleans up obsolete code since we introduced permissionless IP registration and metadata modules with other PRs. However, permissionless IP Registration and metadata modules depend on the new storage.

@LeoHChen LeoHChen merged commit e6ad5af into storyprotocol:main Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants