v1.1 TRST-M-2 Fix nonce type hash calculation for EIP-712

[Ramarti]

Execute.nonce type is changed from uint256 to bytes32. But the execute type
hash, EXECUTE, is not updated and is still using uint256 for the nonce.

/// @dev Execute type hash.
bytes32 public constant EXECUTE =
keccak256("Execute(address to,uint256 value,bytes data,uint256 nonce,uint256 deadline)");

As a result, the execute type hash is incorrectly calculated, breaking EIP-712 compatibility and
potentially causing the signature verification in IPAccountImpl::executeWithSig() to fail.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced security by changing the nonce parameter type from uint256 to bytes32 in meta transactions, improving consistency and reducing potential vulnerabilities.

[coderabbitai]

Walkthrough

The change in the MetaTx.sol involves a modification in the EXECUTE type hash within the MetaTx library. Specifically, the nonce parameter has been updated from uint256 to bytes32. This adjustment enhances the flexibility and security of the nonce parameter.

Changes

Files	Change Summary
contracts/lib/MetaTx.sol	Updated the EXECUTE type hash by changing nonce from uint256 to bytes32.

Poem

🐰 In the land of MetaTx, a change we see,
The nonce now bytes32, dancing with glee.
Security enhanced, flexibility grand,
A future-proof contract, finely planned.
CodeRabbit hops, with joy so fleet,
For this little change, a mighty treat! 🌟

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b2b1e82 and df775ea.

Files selected for processing (1)

• contracts/lib/MetaTx.sol (1 hunks)

Additional comments not posted (2)

contracts/lib/MetaTx.sol (2)

16-16: Update of EXECUTE type hash to use bytes32 for the nonce parameter is correctly implemented.

This change ensures that the hash calculation aligns with the new nonce type, maintaining EIP-712 compatibility.

---

16-16: Ensure consistent use of the updated EXECUTE type hash across all related functions.

The getExecuteStructHash function correctly uses the updated EXECUTE type hash, ensuring consistency in how the nonce field is treated throughout the library.