Refactor registerIpAccount to be Internal function
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
Ramarti,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
jdubpark
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes that refactor the
registerIpAccountfunction in theIPAccountRegistrycontract. The function has been made internal to ensure there is only one unique way to register an IPAccount, which is through theIPAssetRegistry. This change is aimed at making the IP Asset registration path more consistent.Changes:
Modified the
registerIpAccountfunction in theIPAccountRegistrycontract to be internal. This change ensures that IP Account registration can only be done through theIPAssetRegistry, providing a single, consistent path for IP registration.Updated the unit tests to reflect these changes.
Updated the NatSpec documentation to reflect these changes.
Test Plan
Updated the unit test case cover the code changes.