Implement Batch Operations in IPAccountStorage #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
Ramarti,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
LeoHChen
approved these changes
Apr 25, 2024
|
please rebase the code and resolve the conflict. @kingster-will |
kingster-will
force-pushed
the
v11/multicall
branch
from
b2aedba to
84b3d9f
Compare
rebased to the latest. |
jdubpark
reviewed
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces batch operations to the
IPAccountStoragesmart contract, aiming to reduce the number of external calls when setting or retrieving multiple values simultaneously. These enhancements optimize interactions with other contracts or front-end applications, thereby reducing gas costs. As there is already a batch executing function, adding batch operations for setter and getter functions will maintain consistency.Also cleaned up an unused internal function.
Changes
Test Plan
100% coverage by unit tests for new and changed code
Related Issue
Closes #109