forked from storyprotocol/protocol-core
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy with CREATE3 for Deterministic Addresses to Resolve Cyclical Dependencies in Contract Deployment #124
Merged
LeoHChen
merged 7 commits into
storyprotocol:main
from
kingster-will:v11/create3-deploy
Apr 18, 2024
Merged
Deploy with CREATE3 for Deterministic Addresses to Resolve Cyclical Dependencies in Contract Deployment #124
LeoHChen
merged 7 commits into
storyprotocol:main
from
kingster-will:v11/create3-deploy
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingster-will
requested review from
Ramarti,
leeren,
jdubpark,
Spablob,
LeoHChen and
AndyBoWu
as code owners
April 17, 2024 23:49
kingster-will
changed the title
Implement CREATE3 for Deterministic Addresses to Resolve Cyclical Dependencies in Contract Deployment
Deploy with CREATE3 for Deterministic Addresses to Resolve Cyclical Dependencies in Contract Deployment
Apr 17, 2024
jdubpark
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, comments:
- Should we validate the addresses passed in constructors? (We've been doing zero address validation for access manager in initializers)
- This change requires upgrading contracts if any immutable address needs to be changed (new proxy).
Ramarti
requested changes
Apr 18, 2024
LeoHChen
approved these changes
Apr 18, 2024
Added check for empty address in the constructors. |
kingster-will
force-pushed
the
v11/create3-deploy
branch
from
April 18, 2024 17:19
9083c6c
to
889e193
Compare
Ramarti
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the use of
CREATE3
for deploying our smart contracts, an update aimed at resolving the challenges posed by cyclical dependencies during the deployment phase. By leveraging CREATE3, we can deploy contracts to deterministic addresses using a predefined salt. This approach has several advantages and key implementations as detailed below:Benefits:
Tests Plane
All changes are covered by existing automation tests.
Related Issues
Closes #106