Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal refactor to save in storage reads/writes in IpRoyaltyVault #108

Closed
wants to merge 1 commit into from
Closed

Internal refactor to save in storage reads/writes in IpRoyaltyVault #108

wants to merge 1 commit into from

Conversation

Ramarti
Copy link

@Ramarti Ramarti commented Apr 15, 2024

Hashing nested mappings lookups save multiple SLOADs and SSTOREs on royalties.

@Ramarti
Copy link
Author

Ramarti commented Apr 15, 2024 •
edited
Loading

Actually, after better measuring, it's a little more expensive.
[PASS] test_IpRoyaltyVault_AddIpRoyaltyVaultTokens() (gas: 88767)
[PASS] test_IpRoyaltyVault_AddIpRoyaltyVaultTokens_NotRoyaltyPolicyLAP() (gas: 16481)
[PASS] test_IpRoyaltyVault_ClaimRevenueBySnapshotBatch() (gas: 520296)
[PASS] test_IpRoyaltyVault_ClaimRevenueByTokenBatch() (gas: 646251)
[PASS] test_IpRoyaltyVault_ClaimableRevenue() (gas: 371164)
[PASS] test_IpRoyaltyVault_CollectRoyaltyTokens() (gas: 639653)
[PASS] test_IpRoyaltyVault_CollectRoyaltyTokens_AlreadyClaimed() (gas: 157990)
[PASS] test_IpRoyaltyVault_CollectRoyaltyTokens_ClaimerNotAnAncestor() (gas: 77389)
[PASS] test_IpRoyaltyVault_Snapshot() (gas: 1822553)
[PASS] test_IpRoyaltyVault_Snapshot_SnapshotIntervalTooShort() (gas: 31753)
[PASS] test_IpRoyaltyVault_Snapshot_revert_paused() (gas: 68133)
[PASS] test_IpRoyaltyVault_claimRevenue_revert_paused() (gas: 86817)
[PASS] test_IpRoyaltyVault_collectRoyaltyTokens_revert_paused() (gas: 73309)

VS (after)

[PASS] test_IpRoyaltyVault_AddIpRoyaltyVaultTokens() (gas: 88767)
[PASS] test_IpRoyaltyVault_AddIpRoyaltyVaultTokens_NotRoyaltyPolicyLAP() (gas: 16481)
[PASS] test_IpRoyaltyVault_ClaimRevenueBySnapshotBatch() (gas: 521687)
[PASS] test_IpRoyaltyVault_ClaimRevenueByTokenBatch() (gas: 647660)
[PASS] test_IpRoyaltyVault_ClaimableRevenue() (gas: 371594)
[PASS] test_IpRoyaltyVault_CollectRoyaltyTokens() (gas: 639785)
[PASS] test_IpRoyaltyVault_CollectRoyaltyTokens_AlreadyClaimed() (gas: 157990)
[PASS] test_IpRoyaltyVault_CollectRoyaltyTokens_ClaimerNotAnAncestor() (gas: 77389)
[PASS] test_IpRoyaltyVault_Snapshot() (gas: 1823583)
[PASS] test_IpRoyaltyVault_Snapshot_SnapshotIntervalTooShort() (gas: 31753)
[PASS] test_IpRoyaltyVault_Snapshot_revert_paused() (gas: 68133)
[PASS] test_IpRoyaltyVault_claimRevenue_revert_paused() (gas: 86817)
[PASS] test_IpRoyaltyVault_collectRoyaltyTokens_revert_paused() (gas: 73309)

@Ramarti Ramarti closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdubpark jdubpark jdubpark approved these changes

@kingster-will kingster-will Awaiting requested review from kingster-will kingster-will is a code owner

@leeren leeren Awaiting requested review from leeren

@Spablob Spablob Awaiting requested review from Spablob Spablob is a code owner

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramarti @jdubpark