update arbitration policy fix (#317)

storyprotocol · Nov 28, 2024 · c340938 · c340938
1 parent 4bd1147
commit c340938
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/contracts/modules/dispute/DisputeModule.sol b/contracts/modules/dispute/DisputeModule.sol
@@ -173,6 +173,10 @@ contract DisputeModule is
         if (!$.isWhitelistedArbitrationPolicy[nextArbitrationPolicy])
             revert Errors.DisputeModule__NotWhitelistedArbitrationPolicy();
 
+        // if applicable updates the active arbitration policy to the queued arbitration policy
+        // before setting the new next arbitration policy
+        _updateActiveArbitrationPolicy(ipId);
+
         $.nextArbitrationPolicies[ipId] = nextArbitrationPolicy;
 
         uint256 nextArbitrationUpdateTimestamp = block.timestamp + $.arbitrationPolicyCooldown;

diff --git a/test/foundry/modules/dispute/DisputeModule.t.sol b/test/foundry/modules/dispute/DisputeModule.t.sol
@@ -249,6 +249,27 @@ contract DisputeModuleTest is BaseTest {
         assertEq(disputeModule.nextArbitrationUpdateTimestamps(ipAddr), block.timestamp + 7 days);
     }
 
+    function test_DisputeModule_setArbitrationPolicy_WithQueuedPolicy() public {
+        vm.startPrank(u.admin);
+        disputeModule.whitelistArbitrationPolicy(address(mockArbitrationPolicy2), true);
+        vm.stopPrank();
+
+        vm.startPrank(ipAddr);
+
+        vm.expectEmit(true, true, true, true, address(disputeModule));
+        emit IDisputeModule.ArbitrationPolicySet(ipAddr, address(mockArbitrationPolicy2), block.timestamp + 7 days);
+
+        disputeModule.setArbitrationPolicy(ipAddr, address(mockArbitrationPolicy2));
+
+        vm.warp(block.timestamp + disputeModule.arbitrationPolicyCooldown() + 1);
+
+        disputeModule.setArbitrationPolicy(ipAddr, address(mockArbitrationPolicy));
+
+        assertEq(disputeModule.arbitrationPolicies(ipAddr), address(mockArbitrationPolicy2));
+        assertEq(disputeModule.nextArbitrationPolicies(ipAddr), address(mockArbitrationPolicy));
+        assertEq(disputeModule.nextArbitrationUpdateTimestamps(ipAddr), block.timestamp + 7 days);
+    }
+
     function test_DisputeModule_raiseDispute_revert_NotRegisteredIpId() public {
         vm.expectRevert(Errors.DisputeModule__NotRegisteredIpId.selector);
         disputeModule.raiseDispute(address(1), disputeEvidenceHashExample, "IMPROPER_REGISTRATION", "");