Fix empty version in deploy output file name. (#250)

storyprotocol · Sep 19, 2024 · ae0ab98 · ae0ab98
1 parent e51c932
commit ae0ab98
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/script/foundry/deployment/Main.s.sol b/script/foundry/deployment/Main.s.sol
@@ -47,7 +47,8 @@ contract Main is DeployHelper {
         super.run(
             seed, // create3 seed
             false, // runStorageLayoutCheck
-            true // writeDeployments,
+            true, // writeDeployments,
+            VERSION
         );
         _writeDeployment(VERSION); // write deployment json to deployments/deployment-{chainId}.json
     }

diff --git a/script/foundry/utils/DeployHelper.sol b/script/foundry/utils/DeployHelper.sol
@@ -157,9 +157,10 @@ contract DeployHelper is Script, BroadcastManager, JsonDeploymentHandler, Storag
     /// @dev To use, run the following command (e.g. for Sepolia):
     /// forge script script/foundry/deployment/Main.s.sol:Main --rpc-url $RPC_URL --broadcast --verify -vvvv
 
-    function run(uint256 create3SaltSeed_, bool runStorageLayoutCheck, bool writeDeploys_) public virtual {
+    function run(uint256 create3SaltSeed_, bool runStorageLayoutCheck, bool writeDeploys_, string memory version_) public virtual {
         create3SaltSeed = create3SaltSeed_;
         writeDeploys = writeDeploys_;
+        version = version_;
 
         // This will run OZ storage layout check for all contracts. Requires --ffi flag.
         if (runStorageLayoutCheck) super.run();

diff --git a/test/foundry/utils/BaseTest.t.sol b/test/foundry/utils/BaseTest.t.sol
@@ -83,7 +83,8 @@ contract BaseTest is Test, DeployHelper, LicensingHelper {
         super.run(
             CREATE3_DEFAULT_SEED,
             false, // runStorageLayoutCheck
-            false // writeDeploys
+            false, // writeDeploys
+            "test" // version
         );
 
         initLicensingHelper(address(pilTemplate), address(royaltyPolicyLAP), address(erc20));