increase test coverage in IpRoyaltyVault

storyprotocol · Apr 11, 2024 · 6b89756 · 6b89756
1 parent 5c7922a
commit 6b89756
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/contracts/lib/Errors.sol b/contracts/lib/Errors.sol
@@ -287,8 +287,6 @@ library Errors {
     error RoyaltyPolicyLAP__ZeroIpRoyaltyVaultBeacon();
     error RoyaltyPolicyLAP__ZeroAccessManager();
 
-    error IpRoyaltyVault__ZeroIpId();
-    error IpRoyaltyVault__ZeroSupply();
     error IpRoyaltyVault__ZeroRoyaltyPolicyLAP();
     error IpRoyaltyVault__NotRoyaltyPolicyLAP();
     error IpRoyaltyVault__SnapshotIntervalTooShort();

diff --git a/contracts/modules/royalty/policies/IpRoyaltyVault.sol b/contracts/modules/royalty/policies/IpRoyaltyVault.sol
@@ -86,9 +86,6 @@ contract IpRoyaltyVault is IIpRoyaltyVault, ERC20SnapshotUpgradeable, Reentrancy
         uint32 unclaimedTokens,
         address ipIdAddress
     ) external initializer {
-        if (ipIdAddress == address(0)) revert Errors.IpRoyaltyVault__ZeroIpId();
-        if (supply == 0) revert Errors.IpRoyaltyVault__ZeroSupply();
-
         IpRoyaltyVaultStorage storage $ = _getIpRoyaltyVaultStorage();
 
         $.ipId = ipIdAddress;

diff --git a/test/foundry/modules/dispute/ArbitrationPolicySP.t.sol b/test/foundry/modules/dispute/ArbitrationPolicySP.t.sol
@@ -106,10 +106,7 @@ contract TestArbitrationPolicySP is BaseTest {
 
         vm.expectRevert(Errors.ArbitrationPolicySP__ZeroAccessManager.selector);
         arbitrationPolicySP = ArbitrationPolicySP(
-            TestProxyHelper.deployUUPSProxy(
-                impl,
-                abi.encodeCall(ArbitrationPolicySP.initialize, address(0))
-            )
+            TestProxyHelper.deployUUPSProxy(impl, abi.encodeCall(ArbitrationPolicySP.initialize, address(0)))
         );
     }
 

diff --git a/test/foundry/modules/royalty/IpRoyaltyVault.t.sol b/test/foundry/modules/royalty/IpRoyaltyVault.t.sol
@@ -28,6 +28,8 @@ contract TestIpRoyaltyVault is BaseTest {
 
         (, address IpRoyaltyVault2, , , ) = royaltyPolicyLAP.getRoyaltyData(address(2));
         ipRoyaltyVault = IpRoyaltyVault(IpRoyaltyVault2);
+
+        assertEq(ipRoyaltyVault.ipId(), address(2));
     }
 
     function _setupMaxUniqueTree() internal {
@@ -129,14 +131,17 @@ contract TestIpRoyaltyVault is BaseTest {
 
         vm.startPrank(address(licensingModule));
         royaltyModule.onLinkToParents(address(100), address(royaltyPolicyLAP), parents, encodedLicenseData, "");
-        //royaltyPolicyLAP.onLinkToParents(address(100), parents, encodedLicenseData, "");
     }
 
     function test_IpRoyaltyVault_AddIpRoyaltyVaultTokens_NotRoyaltyPolicyLAP() public {
         vm.expectRevert(Errors.IpRoyaltyVault__NotRoyaltyPolicyLAP.selector);
         ipRoyaltyVault.addIpRoyaltyVaultTokens(address(0));
     }
 
+    function test_IpRoyaltyVault_decimals() public {
+        assertEq(ipRoyaltyVault.decimals(), 6);
+    }
+
     function test_IpRoyaltyVault_AddIpRoyaltyVaultTokens() public {
         vm.startPrank(address(royaltyPolicyLAP));
         ipRoyaltyVault.addIpRoyaltyVaultTokens(address(1));