Ensure Initialize Dynamic Results Array for Group Members (#337)

storyprotocol · Dec 10, 2024 · 1404375 · 1404375
1 parent 9d66823
commit 1404375
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/contracts/registries/GroupIPAssetRegistry.sol b/contracts/registries/GroupIPAssetRegistry.sol
@@ -145,9 +145,10 @@ abstract contract GroupIPAssetRegistry is IGroupIPAssetRegistry, ProtocolPausabl
     ) external view returns (address[] memory results) {
         EnumerableSet.AddressSet storage allMemberIpIds = _getGroupIPAssetRegistryStorage().groups[groupId];
         uint256 totalSize = allMemberIpIds.length();
-        if (startIndex >= totalSize) return results;
+        if (startIndex >= totalSize) return new address[](0);
 
         uint256 resultsSize = (startIndex + size) > totalSize ? size - ((startIndex + size) - totalSize) : size;
+        results = new address[](resultsSize);
         for (uint256 i = 0; i < resultsSize; i++) {
             results[i] = allMemberIpIds.at(startIndex + i);
         }