Skip to content

Commit

Permalink
nit: comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jdubpark committed Apr 16, 2024
1 parent 38782a8 commit 0c72576
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 2 additions & 3 deletions contracts/access/AccessController.sol
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ contract AccessController is IAccessController, ProtocolPausableUpgradeable, UUP
}

/// @notice Sets the addresses of the IP account registry and the module registry
/// @dev TODO: figure out how to set these addresses in the constructor to make them immutable
/// @dev TODO: Set these addresses in the constructor to make them immutable
/// @param ipAccountRegistry address of the IP account registry
/// @param moduleRegistry address of the module registry
function setAddresses(address ipAccountRegistry, address moduleRegistry) external restricted {
Expand All @@ -75,10 +75,9 @@ contract AccessController is IAccessController, ProtocolPausableUpgradeable, UUP
}

/// @notice Sets a batch of permissions in a single transaction.
/// @dev This function allows setting multiple permissions at once. Pausable.
/// @dev This function allows setting multiple permissions at once. Pausable via setPermission.
/// @param permissions An array of `Permission` structs, each representing the permission to be set.
function setBatchPermissions(AccessPermission.Permission[] memory permissions) external {
// TODO: removed pause.
for (uint256 i = 0; i < permissions.length; ) {
setPermission(
permissions[i].ipAccount,
Expand Down
2 changes: 0 additions & 2 deletions contracts/interfaces/registries/ILicenseRegistry.sol
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ interface ILicenseRegistry {
/// @return Whether the IP has derivative IPs.
function hasDerivativeIps(address ipId) external view returns (bool);

// TODO: getDerivativeIpCount

/// @notice Verifies the minting of a license token.
/// @param licensorIpId The address of the licensor IP.
/// @param licenseTemplate The address of the license template where the license terms are defined.
Expand Down

0 comments on commit 0c72576

Please sign in to comment.