Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view visibility #249

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix view visibility #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/interfaces/modules/registration/IRegistrationModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ interface IRegistrationModule is IModule {
/// @notice Gets the IP asset id associated with an IP Org asset.
/// @param ipOrg_ The address of the governing IP asset IP Org.
/// @param ipOrgAssetId_ The localized id of the IP asset within the IP Org.
function ipAssetId(address ipOrg_, uint256 ipOrgAssetId_) external returns (uint256);
function ipAssetId(address ipOrg_, uint256 ipOrgAssetId_) external view returns (uint256);

/// @notice Renders metadata of an IP Asset localized for an IP Org.
/// @param ipOrg_ The address of the IP Org of the IP asset.
Expand Down
2 changes: 1 addition & 1 deletion contracts/ip-org/IPOrg.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ contract IPOrg is IIPOrg, ERC721Upgradeable {
/// @notice Gets the global IP asset id associated with this IP Org asset.
/// @param id_ The local id of the IP Org wrapped IP asset.
/// @return The global identifier of the IP asset.
function ipAssetId(uint256 id_) public returns (uint256) {
function ipAssetId(uint256 id_) public view returns (uint256) {
address registrationModule = address(MODULE_REGISTRY.protocolModule(REGISTRATION_MODULE_KEY));
return IRegistrationModule(registrationModule).ipAssetId(address(this), id_);
}
Expand Down