Release: Prerelease 8.4.0-alpha.5 #29292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Migrates away from express, instead using connect and the underlying node server directly. Both express and connect support the same middleware structure, which means most middleware packages work for both and have remained the same in this change. A few notes: - Express' router has been replaced by basic connect mount points (though the two are not equivalent exactly) - Express static has been replaced by sirv This trims a large sub-tree of dependencies from our packages which express was pulling in. We in fact use very little of the functionality express gives us, only really making use of the connect-style API anyway.
Migrates from express to polka 1.x.
Build: Disallowed certain packages via ESlint
Maintenance: Remove dependence on `file-system-cache`
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
28 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
| const options = { | ||
| ...cliOptions, | ||
| configDir: cliOptions.configDir || './.storybook', | ||
| configType: 'DEVELOPMENT', | ||
| ignorePreview: !!cliOptions.previewUrl && !cliOptions.forceBuildPreview, | ||
| cache, | ||
| cache: cache as any, |
There was a problem hiding this comment.
style: Cast cache to 'any' to avoid potential type conflicts
Comment on lines
+54
to
+57
| private parseCacheData<T>(data: string, fallback: T | null): T | null { | ||
| const parsed = JSON.parse(data); | ||
| return this.isExpired(parsed, Date.now()) ? fallback : (parsed.content as T); | ||
| } |
There was a problem hiding this comment.
style: Add error handling for JSON.parse to prevent crashes on invalid data
Comment on lines
+10
to
11
| // eslint-disable-next-line depend/ban-dependencies | ||
| import execa from 'execa'; |
There was a problem hiding this comment.
style: Consider moving this eslint-disable comment to a more specific line or finding an alternative to 'execa' that doesn't require disabling the rule.
Build: Filter out @storybook/root from buildable packages
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.4
branch
from
11d5e25
to
633da81
Compare
Core: Migrate from `express` to `polka`
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.4
branch
from
633da81
to
f0e4c35
Compare
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.4
branch
from
f0e4c35
to
6e32f1c
Compare
shilman
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6e32f1c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.4.0-alpha.4to8.4.0-alpha.5.Once this pull request is merged, it will trigger a new release of version
8.4.0-alpha.5.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:expresstopolka#29230file-system-cache#29256If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.0-alpha.5
expresstopolka- #29230, thanks @43081j!file-system-cache- #29256, thanks @ndelangen!