Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Migrate from express to polka #29230

Merged
merged 43 commits into from
Oct 8, 2024
Merged

Core: Migrate from express to polka #29230

merged 43 commits into from
Oct 8, 2024

Commits on May 6, 2024

  1. feat: migrate from express to connect 

    Migrates away from express, instead using connect and the underlying
node server directly.

Both express and connect support the same middleware structure, which
means most middleware packages work for both and have remained the same
in this change.

A few notes:

- Express' router has been replaced by basic connect mount points
(though the two are not equivalent exactly)
- Express static has been replaced by sirv

This trims a large sub-tree of dependencies from our packages which
express was pulling in. We in fact use very little of the functionality
express gives us, only really making use of the connect-style API
anyway.
    @43081j
    43081j committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a725eda View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. fix

    @ndelangen
    ndelangen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9b0b42a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into pr/43081j/27045

    @ndelangen
    ndelangen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c2261fd View commit details
    Browse the repository at this point in the history

  3. fix linting

    @ndelangen
    ndelangen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8129229 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'next' into without-express

    @ndelangen
    ndelangen authored May 7, 2024
    Configuration menu
    Copy the full SHA
    644582f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'next' into without-express

    @43081j
    43081j committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f1685e7 View commit details
    Browse the repository at this point in the history

  6. test: fix stories-json test assertions

    @43081j
    43081j committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ffa4f0b View commit details
    Browse the repository at this point in the history

  7. fix(core-server): remove unused import

    @43081j
    43081j committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b92d83b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'next' into without-express

    @ndelangen
    ndelangen authored May 8, 2024
    Configuration menu
    Copy the full SHA
    de5724b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into without-express

    @ndelangen
    ndelangen authored May 8, 2024
    Configuration menu
    Copy the full SHA
    480b07b View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Merge branch 'next' into without-express

    @43081j
    43081j committed May 18, 2024
    Configuration menu
    Copy the full SHA
    66d27f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'next' into without-express

    @43081j
    43081j committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c515678 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'next' into pr/43081j/27045

    @ndelangen
    ndelangen committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7832789 View commit details
    Browse the repository at this point in the history

  2. update branch with CPC work

    @ndelangen
    ndelangen committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2940276 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Merge branch 'next' into without-express

    @ndelangen
    ndelangen authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e48040d View commit details
    Browse the repository at this point in the history

  2. remove express types

    @ndelangen
    ndelangen committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    88fbc1b View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Merge branch 'next' into without-express

    @43081j
    43081j committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    97d65b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'next' into pr/43081j/27045

    @ndelangen
    ndelangen committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9e3cd4d View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Merge branch 'next' into without-express

    @43081j
    43081j committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    c18aedb View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'next' into without-express-polka

    @43081j
    43081j committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4c2a2d4 View commit details
    Browse the repository at this point in the history

  2. feat: migrate from express to polka 

    Migrates from express to polka 1.x.
    @43081j
    43081j committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    841777d View commit details
    Browse the repository at this point in the history

  3. fix: revert a few changes

    @43081j
    43081j committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    056a37c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. listen for requests, cleanup

    @JReinhold
    JReinhold committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cce0f14 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. comment update

    @JReinhold
    JReinhold committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b64c7cf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' of github.com:storybookjs/storybook into without-… 

    …express-polka
    @JReinhold
    JReinhold committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    baa53b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. remove custom content-type headers

    @JReinhold
    JReinhold committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4fd94e6 View commit details
    Browse the repository at this point in the history

  2. make polka a dev dep of builder-vite

    @JReinhold
    JReinhold committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0cafba6 View commit details
    Browse the repository at this point in the history

  3. prebundle polka, sirv

    @JReinhold
    JReinhold committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    31ca3f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. revert to existing static serving logic

    @JReinhold
    JReinhold committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d85dc51 View commit details
    Browse the repository at this point in the history

  2. cleanup express dependencies

    @JReinhold
    JReinhold committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8f7f881 View commit details
    Browse the repository at this point in the history

  3. Don't expose Polka typings

    @JReinhold
    JReinhold committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2b4803e View commit details
    Browse the repository at this point in the history

  4. fix middleware types

    @JReinhold
    JReinhold committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ffef33c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. only expose router to builders

    @JReinhold
    JReinhold committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b563eee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' of github.com:storybookjs/storybook into without-… 

    …express-polka
    @JReinhold
    JReinhold committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    66eddc5 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix ServerApp types to match Polka/Trouter

    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9fa3ee2 View commit details
    Browse the repository at this point in the history

  2. migrate event log server to polka

    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0f86686 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'next' into without-express-polka

    @JReinhold
    JReinhold authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7e4313f View commit details
    Browse the repository at this point in the history

  4. cleanup

    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e6e745b View commit details
    Browse the repository at this point in the history

  5. wait for server to listen

    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    49483aa View commit details
    Browse the repository at this point in the history

  6. Merge branch 'next' of github.com:storybookjs/storybook into without-… 

    …express-polka
    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f0151ea View commit details
    Browse the repository at this point in the history

  7. fix format

    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9fcba90 View commit details
    Browse the repository at this point in the history

  8. regenerate lock-file

    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    68f5724 View commit details
    Browse the repository at this point in the history

  9. fix formatting

    @JReinhold
    JReinhold committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6c3a0bb View commit details
    Browse the repository at this point in the history