Merge pull request #23804 from sookmax/fix-undefined-addon-state

Manager API: Fix `api.getAddonState`default value
storybookjs · Aug 23, 2023 · 1c465ce · 1c465ce
2 parents fd9aa21 + 503b18c
commit 1c465ce
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/code/lib/manager-api/src/index.tsx b/code/lib/manager-api/src/index.tsx
@@ -399,11 +399,13 @@ export function useSharedState<S>(stateId: string, defaultState?: S) {
     addonStateCache[stateId] ? addonStateCache[stateId] : defaultState
   );
 
-  if (api.getAddonState(stateId) && api.getAddonState(stateId) !== state) {
-    api.setAddonState<S>(stateId, state).then((s) => {
-      addonStateCache[stateId] = s;
-    });
-  }
+  useEffect(() => {
+    if (api.getAddonState(stateId) === undefined && api.getAddonState(stateId) !== state) {
+      api.setAddonState<S>(stateId, state).then((s) => {
+        addonStateCache[stateId] = s;
+      });
+    }
+  }, [api]);
 
   const setState = (s: S | API_StateMerger<S>, options?: Options) => {
     const result = api.setAddonState<S>(stateId, s, options);