Add check for src-less scripts in preview #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrashr888
changed the title
|
Also ran into this. The fix in this PR seems to work on my end, but I do get a non-blocking error within storybook though 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My app uses
ember-cli-segment, which adds a script tag (something similar to a Google Analytics tag) to my HTML. It ends up in the preview with a<script type="text/javascript">tag. The build fails with aCannot read property 'indexOf' of undefinederror on line 121 here, then on line 140 once that's fixed. This PR adds checks to avoid callingindexOfon script tags withoutsrcattributes.I looked at the test and I'm not sure how you'd want to test it? I imagine the existing tests might fail if a
Object { "type": "text/javascript", },is added, but now they'll pass?Thanks.