chore: update eslint, using our shared conf, and update every dev deps #866
Conversation
There was a problem hiding this comment.
Hey @edodusi, thanks for this PR! A few small changes left to do after reviewing the internal checklist of things to update:
- Update to Node LTS here, here, here and here (if somehow the version can be unified in a single place, that'd be amazing)
- Update to latest Semantic Release https://github.com/storyblok/storyblok-js-client/blob/main/.github/workflows/release.yml#L32
Also in the ticket we defined to remove husky and lint-staged, towards the approach of having a lint job in the CI doing this, but I don't see the change here. Is it on track or there is a particular reason not to have it?
Yes, I second what @alexjoverm mentions here, we are aiming to replace the pre-push strategy of husky with CI/CD checks. You can check this example on how is enabled in the nuxt package storyblok/storyblok-nuxt@a22f89b . Let me know if you have any questions |
There was a problem hiding this comment.
@edodusi Since adding the Lint CI action is part of the strategy of replacing the pre-push husky one I would include it on the scope of this PR. Check storyblok/storyblok-nuxt@a22f89b for inspo
commit: |
…ode version in actions
|
@alexjoverm @alvarosabu changes made 👀 |
|
🎉 This PR is included in version 6.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull request type
Package update, linting refactoring
How to test this PR
Update the dependency in any running project: nothing should break.
What is the new behavior?
Style changes.
Other information