Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve cv cache flushing #847

Merged
merged 3 commits into from
Oct 1, 2024
Merged

feat: improve cv cache flushing #847

merged 3 commits into from
Oct 1, 2024

Conversation

juusopiikkila
Copy link
Contributor

@juusopiikkila juusopiikkila commented Aug 2, 2024

Pull request type

Please check the type of change your PR introduces:-->

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

What is the new behavior?

With this change the cv cache is now flushed even with published versions so that the content is kept up to date. Fixes issue #823.

src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juusopiikkila Thanks a lot for this fix, I tested it and seems to solve the issue with cache and published versions

@alvarosabu alvarosabu added the feature [Issue] New feature or request label Oct 1, 2024
@alvarosabu alvarosabu self-assigned this Oct 1, 2024
@alvarosabu alvarosabu added the p4-important [Priority] Violate documented behavior or significantly improve performance (priority) label Oct 1, 2024
@alvarosabu alvarosabu linked an issue Oct 1, 2024 that may be closed by this pull request
@alvarosabu alvarosabu merged commit ea68845 into storyblok:main Oct 1, 2024
1 of 2 checks passed
Copy link

github-actions bot commented Oct 1, 2024

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Issue] New feature or request p4-important [Priority] Violate documented behavior or significantly improve performance (priority) released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cache Version (cv) Properly After API Response
3 participants