fix: get proper binding for the fetch function #713
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team, this issue is important as it makes js-client unusable. The fix is on the binding of
fetch
which is bound to the instance of the client instead ofwindow
. Check this stackoverflow thread for more info: https://stackoverflow.com/questions/44720448/fetch-typeerror-failed-to-execute-fetch-on-window-illegal-invocationBtw, I know the type
any
is not ideal but as this is blocking we can improve that later.Pull request type
How to test this PR
npm run build
to ensure you're using latest js-client distcd playground-svelte
, runnpm i
, and runnpm run demo
. Openhttp://localhost:5174/
in the browser and all should be good (as in image 1 below) - ISSUE FIXEDsrc/sbFetch
line 33, change is as it was beforethis.fetch = $c.fetch(args) || fetch(args)
, and in terminal A runnpm run build
againfetch
function is failing (as in image 2 below) - CURRENT ISSUEIMAGE 1 - ALL GOOD
IMAGE 2 - FETCH FAILING