-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(header): creating a SbHeader component #431
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
because it breaks the app (probably due to a conflict with @/utils that it's both in the app project and in the DS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WithoutButton.parameters = { | ||
docs: { | ||
description: { | ||
story: 'Types of buttons with loading.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here the description is incorrect, because the story is about having no button, and this description is also used in the next story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right! Bloody copy-paste! 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small comment about the description of a single story (Without a button). The rest is ok. Congrats team.
🎉 This PR is included in version 3.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull request type
How to test this PR