feat(header): creating a SbHeader component #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fernandacanto
requested review from
lisilinhart,
emanuelgsouza and
ademarCardoso
because it breaks the app (probably due to a conflict with @/utils that it's both in the app project and in the DS)
| WithoutButton.parameters = { | ||
| docs: { | ||
| description: { | ||
| story: 'Types of buttons with loading.', |
There was a problem hiding this comment.
I think here the description is incorrect, because the story is about having no button, and this description is also used in the next story.
There was a problem hiding this comment.
you're right! Bloody copy-paste! 😂
emanuelgsouza
approved these changes
Jul 19, 2023
fariacc
approved these changes
Jul 19, 2023
|
🎉 This PR is included in version 3.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
How to test this PR