lvm: Use pvremove when removing PVs after deleting a VG #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udisks_daemon_util_lvm2_wipe_block is a huge hammer that also tries to call vgreduce and pvscan and does other steps that are not necessary when removing the PV signature after removing the VG. Fixes: storaged-project#1228
tbzatek
approved these changes
Jan 4, 2024
|
Cc: @mvollmer |
These can be useful when removing PV from an existing VG (but I think running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
udisks_daemon_util_lvm2_wipe_block is a huge hammer that also tries to call vgreduce and pvscan and does other steps that are not necessary when removing the PV signature after removing the VG.
Fixes: #1228