modules/btrfs: add SetDefaultSubvolumeID #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vojtechtrefny
approved these changes
Nov 22, 2023
|
Jenkins, ok to test. |
src/tests/dbus-tests/test_btrfs.py
Outdated
| @@ -399,3 +399,10 @@ def test_get_default_subvolume_id(self): | |||
| default_id = dev.obj.GetDefaultSubvolumeID(self.no_options, | |||
| dbus_interface=self.iface_prefix + '.Filesystem.BTRFS') | |||
| self.assertEqual(default_id, 5) | |||
|
|
|||
| dev.obj.SetDefaultSubvolumeID(5, self.no_options, | |||
There was a problem hiding this comment.
This needs to be dbus.UInt32(5), 5 is treated as int32 by Python DBus.
tbzatek
approved these changes
Nov 23, 2023
libblockdev provides a method to set the default subvolume id since 2014. This method does requires administrative privileges as it changes the default mount target subvolume of a btrfs volume.
jelly
force-pushed
the
set-default-btrfs-subvol-id
branch
from
0a208bd
to
33d2271
Compare
vojtechtrefny
merged commit 4f24c90
into
storaged-project:master
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libblockdev provides a method to set the default subvolume id since
2014. This method does requires administrative privileges as it changes the default mount target subvolume of a btrfs volume.
Turns out I was wrong and thought libblockdev did not provide a method for it but it has a slightly different name.