Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify announce address #48

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: simplify announce address #48

merged 1 commit into from
Nov 26, 2024

Conversation

alanshaw
Copy link
Member

Peer ID seems not needed.

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/aws/service.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/aws/service.go 0.00% <0.00%> (ø)

@alanshaw alanshaw merged commit ce5e877 into main Nov 26, 2024
7 of 8 checks passed
@alanshaw alanshaw deleted the fix/simplify-announce-addr branch November 26, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volmedo volmedo volmedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @volmedo