Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attach blocks to delegation #27

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Oct 21, 2024

This PR adds a method Attach to Delegation that allows additional blocks to be attached. The primary usecase is to allow blocks linked from capabilities or facts to be included in the delegation payload.

Note: this feature exists in JS Ucanto already and it actually validates the blocks you attach are referenced from capabilities/facts. I will open an issue to track feature parity here assuming this is approved.

Copy link
Member

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM gotta love full power to just add blocks

(get the use case FWIW)

@alanshaw alanshaw merged commit 7edcd37 into main Oct 22, 2024
1 check passed
@alanshaw alanshaw deleted the feat/attach-blocks-to-delegation branch October 22, 2024 08:25
alanshaw added a commit to storacha/storage that referenced this pull request Oct 22, 2024
This PR allows configuration of the indexing service DID/URL and
upgrades `publisher.Publish(...)` to make a `claim/cache` invocation to
it.

TODO: actually send the claim in the invocation blocks (needs ucanto
upgrade). See: storacha/go-ucanto#27
alanshaw added a commit to storacha/storage that referenced this pull request Oct 22, 2024
This PR allows configuration of the indexing service DID/URL and upgrades `publisher.Publish(...)` to make a `claim/cache` invocation to it.

TODO: actually send the claim in the invocation blocks (needs ucanto upgrade). See: storacha/go-ucanto#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants