feat: add blob handler #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
approved these changes
May 6, 2024
| export function withBlobHandler (handler) { | ||
| return async (request, env, ctx) => { | ||
| const url = new URL(request.url) | ||
| if (!url.pathname.startsWith('/blob/')) { |
There was a problem hiding this comment.
Do we even need the /blob/ interface as in is there reason why we would not use RAW cid handler instead ? If we did query content claims for raw blocks we would effectively get pointer to the file covering it's full content would not we ?
There was a problem hiding this comment.
Agree, lets move this into the raw handler.
There was a problem hiding this comment.
yes, I also agree, and think actually having /blob will just make everything more complicated on the reads side
This was referenced May 13, 2024
alanshaw
pushed a commit
to storacha/dagula
that referenced
this pull request
May 14, 2024
This PR adds a `streamBlock(cid, [options])` method to Dagula that returns a `ReadableStream` of block bytes. You can optionally pass a byte range to extract a subset of bytes. Also `statBlock(cid, [options])` that retrieves block info i.e. total size in bytes. The idea is to allow dagula to serve byte ranges from big blocks without having to load the whole thing into memory. BREAKING CHANGE: The `Blockstore` interface now includes a `stream` method that returns a `ReadableStream` and a `stat` method that returns info (byte size). The format for the `entityBytes` option of `getPath` has changed. It is now an array of 1 or 2 numbers. See `Range` type for more details. refs storacha/freeway#100 (comment)
alanshaw
pushed a commit
to storacha/gateway-lib
that referenced
this pull request
May 14, 2024
Supports byte ranges for raw block requests - including multipart. depends on storacha/dagula#44 refs storacha/freeway#100 (comment) BREAKING CHANGE: dependencies for handlers have changed, splitting out block, DAG and unixfs services. These are all satisfied by the `Dagula` class for the time being.
alanshaw
pushed a commit
that referenced
this pull request
May 15, 2024
Pulls in latest gateway-lib and dagula to allow byte range requests to raw blocks (`?format=raw`). supersedes #100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
GET/blob/:multihashrefs storacha/w3infra#363